Skip to content

Commit be14eed

Browse files
Apply suggestions from code review
Co-authored-by: Brandy Carney <[email protected]>
1 parent bad0049 commit be14eed

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

core/src/components/select-modal/select-modal.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,12 @@ export class SelectModal implements ComponentInterface {
4444
const { multiple, options } = this;
4545

4646
if (multiple) {
47-
// this is a popover with checkboxes (multiple value select)
47+
// this is a modal with checkboxes (multiple value select)
4848
// return an array of all the checked values
4949
return options.filter((o) => o.checked).map((o) => o.value);
5050
}
5151

52-
// this is a popover with radio buttons (single value select)
52+
// this is a modal with radio buttons (single value select)
5353
// return the value that was clicked, otherwise undefined
5454
const option = ev ? this.findOptionFromEvent(ev) : null;
5555
return option ? option.value : undefined;
@@ -67,7 +67,7 @@ export class SelectModal implements ComponentInterface {
6767
const { multiple } = this;
6868
const option = this.findOptionFromEvent(ev);
6969

70-
// this is a popover with checkboxes (multiple value select)
70+
// this is a modal with checkboxes (multiple value select)
7171
// we need to set the checked value for this option
7272
if (multiple && option) {
7373
option.checked = ev.detail.checked;

0 commit comments

Comments
 (0)