refactor(angular): popover controller uses correct core instance (#28485)

Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->

As a takeaway from our learning session about a menuController bug in
Ionic Angular, the team would like to update our other providers to use
the same architecture as the menuController to prevent this kind of
issue from happening again in the future.

We also noticed that the common provider does not provide much value and
it's easier to just have two separate implementations in src and
standalone. (There wasn't much code we could de-duplicate)

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Removed the common popover provider in favor of separate ones in
src/standalone

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->

I didn't add tests because there's already existing ones for popover
controller.

Author: thetaPC

packages/angular/common/src/index.ts

@@ -3,7 +3,6 @@ export { LoadingController } from './providers/loading-controller';
 export { MenuController } from './providers/menu-controller';
 export { ModalController } from './providers/modal-controller';
 export { PickerController } from './providers/picker-controller';
-export { PopoverController } from './providers/popover-controller';
 export { ToastController } from './providers/toast-controller';
 
 export { AnimationController } from './providers/animation-controller';

packages/angular/common/src/utils/overlay.ts

@@ -1,6 +1,6 @@
 // TODO(FW-2827): types
 
-interface ControllerShape<Opts, HTMLElm> {
+export interface ControllerShape<Opts, HTMLElm> {
   create(options: Opts): Promise<HTMLElm>;
   dismiss(data?: any, role?: string, id?: string): Promise<boolean>;
   getTop(): Promise<HTMLElm | undefined>;

packages/angular/src/index.ts

@@ -24,7 +24,6 @@ export {
   LoadingController,
   ModalController,
   PickerController,
-  PopoverController,
   ToastController,
   AnimationController,
   GestureController,
@@ -41,6 +40,7 @@ export {
   ViewDidLeave,
 } from '@ionic/angular/common';
 export { MenuController } from './providers/menu-controller';
+export { PopoverController } from './providers/popover-controller';
 export { ActionSheetController } from './providers/action-sheet-controller';
 
 // PACKAGE MODULE

packages/angular/src/ionic-module.ts

@@ -1,12 +1,6 @@
 import { CommonModule, DOCUMENT } from '@angular/common';
 import { ModuleWithProviders, APP_INITIALIZER, NgModule, NgZone } from '@angular/core';
-import {
-  ModalController,
-  PopoverController,
-  ConfigToken,
-  AngularDelegate,
-  provideComponentInputBinding,
-} from '@ionic/angular/common';
+import { ModalController, ConfigToken, AngularDelegate, provideComponentInputBinding } from '@ionic/angular/common';
 import { IonicConfig } from '@ionic/core';
 
 import { appInitialize } from './app-initialize';
@@ -29,6 +23,7 @@ import { IonModal } from './directives/overlays/modal';
 import { IonPopover } from './directives/overlays/popover';
 import { DIRECTIVES } from './directives/proxies-list';
 import { IonMaxValidator, IonMinValidator } from './directives/validators';
+import { PopoverController } from './providers/popover-controller';
 
 const DECLARATIONS = [
   // generated proxies

packages/angular/src/providers/popover-controller.ts

@@ -0,0 +1,21 @@
+import { Injector, inject, EnvironmentInjector } from '@angular/core';
+import { AngularDelegate, OverlayBaseController } from '@ionic/angular/common';
+import type { PopoverOptions } from '@ionic/core';
+import { popoverController } from '@ionic/core';
+
+export class PopoverController extends OverlayBaseController<PopoverOptions, HTMLIonPopoverElement> {
+  private angularDelegate = inject(AngularDelegate);
+  private injector = inject(Injector);
+  private environmentInjector = inject(EnvironmentInjector);
+
+  constructor() {
+    super(popoverController);
+  }
+
+  create(opts: PopoverOptions): Promise<HTMLIonPopoverElement> {
+    return super.create({
+      ...opts,
+      delegate: this.angularDelegate.create(this.environmentInjector, this.injector, 'popover'),
+    });
+  }
+}

packages/angular/standalone/src/index.ts

@@ -6,13 +6,13 @@ export { IonRouterLink, IonRouterLinkWithHref } from './navigation/router-link-d
 export { IonTabs } from './navigation/tabs';
 export { provideIonicAngular } from './providers/ionic-angular';
 export { MenuController } from './providers/menu-controller';
+export { PopoverController } from './providers/popover-controller';
 export { ActionSheetController } from './providers/action-sheet-controller';
 export {
   AlertController,
   LoadingController,
   ModalController,
   PickerController,
-  PopoverController,
   ToastController,
   AnimationController,
   GestureController,

packages/angular/standalone/src/providers/ionic-angular.ts

@@ -1,16 +1,12 @@
 import { DOCUMENT } from '@angular/common';
 import { APP_INITIALIZER } from '@angular/core';
 import type { Provider } from '@angular/core';
-import {
-  AngularDelegate,
-  ConfigToken,
-  ModalController,
-  PopoverController,
-  provideComponentInputBinding,
-} from '@ionic/angular/common';
+import { AngularDelegate, ConfigToken, ModalController, provideComponentInputBinding } from '@ionic/angular/common';
 import { initialize } from '@ionic/core/components';
 import type { IonicConfig } from '@ionic/core/components';
 
+import { PopoverController } from './popover-controller';
+
 export const provideIonicAngular = (config?: IonicConfig): Provider[] => {
   /**
    * TODO FW-4967

packages/angular/common/src/providers/popover-controller.ts renamed to packages/angular/standalone/src/providers/popover-controller.ts

@@ -1,12 +1,8 @@
-import { Injector, Injectable, inject, EnvironmentInjector } from '@angular/core';
+import { Injector, inject, EnvironmentInjector } from '@angular/core';
+import { AngularDelegate, OverlayBaseController } from '@ionic/angular/common';
 import type { PopoverOptions } from '@ionic/core/components';
 import { popoverController } from '@ionic/core/components';
 
-import { OverlayBaseController } from '../utils/overlay';
-
-import { AngularDelegate } from './angular-delegate';
-
-@Injectable()
 export class PopoverController extends OverlayBaseController<PopoverOptions, HTMLIonPopoverElement> {
   private angularDelegate = inject(AngularDelegate);
   private injector = inject(Injector);