fix(modal): release cached parent when it's removed from DOM to prevent a leak

Author: ShaneK

core/src/components/modal/modal.tsx

@@ -404,6 +404,7 @@ export class Modal implements ComponentInterface, OverlayInterface {
     this.triggerController.removeClickListener();
     this.cleanupViewTransitionListener();
     this.cleanupParentRemovalObserver();
+    this.cachedOriginalParent = undefined;
   }
 
   componentWillLoad() {
@@ -1200,6 +1201,9 @@ export class Modal implements ComponentInterface, OverlayInterface {
 
           if (cachedParentWasRemoved || cachedParentDisconnected) {
             this.dismiss(undefined, 'parent-removed');
+            // Release the reference to the cached original parent
+            // so we don't have a memory leak
+            this.cachedOriginalParent = undefined;
           }
         }
       });
@@ -1213,10 +1217,8 @@ export class Modal implements ComponentInterface, OverlayInterface {
   }
 
   private cleanupParentRemovalObserver() {
-    if (this.parentRemovalObserver) {
-      this.parentRemovalObserver.disconnect();
-      this.parentRemovalObserver = undefined;
-    }
+    this.parentRemovalObserver?.disconnect();
+    this.parentRemovalObserver = undefined;
   }
 
   render() {