Skip to content

Commit cd68811

Browse files
committed
fix(overlays): announce info after opening an overlay
1 parent 470decc commit cd68811

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

core/src/utils/overlays.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -524,7 +524,7 @@ export const present = async <OverlayPresentOptions>(
524524
document.body.classList.add(BACKDROP_NO_SCROLL);
525525

526526
hideUnderlyingOverlaysFromScreenReaders(overlay.el);
527-
hideAnimatingOverlayFromScreenReaders(overlay.el);
527+
// hideAnimatingOverlayFromScreenReaders(overlay.el);
528528

529529
overlay.presented = true;
530530
overlay.willPresent.emit();
@@ -677,7 +677,7 @@ export const dismiss = async <OverlayDismissOptions>(
677677
* the dismiss animation. This is because the overlay will be removed
678678
* from the DOM after the animation is complete.
679679
*/
680-
hideAnimatingOverlayFromScreenReaders(overlay.el);
680+
// hideAnimatingOverlayFromScreenReaders(overlay.el);
681681

682682
// Overlay contents should not be clickable during dismiss
683683
overlay.el.style.setProperty('pointer-events', 'none');
@@ -977,15 +977,15 @@ export const createTriggerController = () => {
977977
*
978978
* @param overlay - The overlay that is being animated.
979979
*/
980-
const hideAnimatingOverlayFromScreenReaders = (overlay: HTMLIonOverlayElement) => {
981-
if (doc === undefined) return;
982-
983-
/**
984-
* Once the animation is complete, this attribute will be removed.
985-
* This is done at the end of the `present` method.
986-
*/
987-
overlay.setAttribute('aria-hidden', 'true');
988-
};
980+
// const hideAnimatingOverlayFromScreenReaders = (overlay: HTMLIonOverlayElement) => {
981+
// if (doc === undefined) return;
982+
983+
// /**
984+
// * Once the animation is complete, this attribute will be removed.
985+
// * This is done at the end of the `present` method.
986+
// */
987+
// overlay.setAttribute('aria-hidden', 'true');
988+
// };
989989

990990
/**
991991
* Ensure that underlying overlays have aria-hidden if necessary so that screen readers

0 commit comments

Comments
 (0)