refactor: remove extra typescript dependency (#28220)

Author: liamdebeasi

core/package-lock.json

@@ -53,8 +53,8 @@
     "@stencil/vue-output-target": "^0.8.6",
     "@types/jest": "^27.5.2",
     "@types/node": "^14.6.0",
-    "@typescript-eslint/eslint-plugin": "^5.17.0",
-    "@typescript-eslint/parser": "^5.17.0",
+    "@typescript-eslint/eslint-plugin": "^6.7.2",
+    "@typescript-eslint/parser": "^6.7.2",
     "clean-css-cli": "^5.6.1",
     "domino": "^2.1.6",
     "eslint": "^7.32.0",
@@ -69,8 +69,7 @@
     "sass": "^1.26.10",
     "serve": "^14.0.1",
     "stylelint": "^13.13.1",
-    "stylelint-order": "^4.1.0",
-    "typescript": "^4.0.5"
+    "stylelint-order": "^4.1.0"
   },
   "scripts": {
     "build": "npm run clean && npm run build.css && stencil build --es5 --docs-json dist/docs.json",

core/package.json

@@ -1,11 +1,3 @@
-/**
- * Typescript 4.x does not recognize hourCycle as a valid option.
- * See https://github.com/microsoft/TypeScript/issues/34399.
- */
-interface DatetimeFormatOptions extends Intl.ResolvedDateTimeFormatOptions {
-  hourCycle?: 'h11' | 'h12' | 'h23' | 'h24';
-}
-
 /**
  * Determines if given year is a
  * leap year. Returns `true` if year
@@ -32,7 +24,7 @@ export const is24Hour = (locale: string, hourCycle?: 'h23' | 'h12') => {
    * option into the locale string. Example: `en-US-u-hc-h23`
    */
   const formatted = new Intl.DateTimeFormat(locale, { hour: 'numeric' });
-  const options = formatted.resolvedOptions() as DatetimeFormatOptions;
+  const options = formatted.resolvedOptions();
   if (options.hourCycle !== undefined) {
     return options.hourCycle === 'h23';
   }

core/src/components/datetime/utils/helpers.ts

@@ -901,6 +901,7 @@ export class Nav implements NavOutlet {
       : undefined;
     const mode = getIonMode(this);
     const enteringEl = enteringView.element!;
+    // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
     const leavingEl = leavingView && leavingView.element!;
     const animationOpts: TransitionOptions = {
       mode,

core/src/components/nav/nav.tsx

@@ -312,6 +312,7 @@ export class Router implements ComponentInterface {
     const routes = readRoutes(this.el);
 
     const fromChain = findChainForSegments(from, routes);
+    // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
     const beforeLeaveHook = fromChain && fromChain[fromChain.length - 1].beforeLeave;
 
     const canLeave = beforeLeaveHook ? await beforeLeaveHook() : true;
@@ -320,6 +321,7 @@ export class Router implements ComponentInterface {
     }
 
     const toChain = findChainForSegments(to, routes);
+    // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
     const beforeEnterHook = toChain && toChain[toChain.length - 1].beforeEnter;
 
     return beforeEnterHook ? beforeEnterHook() : true;

core/src/components/router/router.tsx

@@ -48,6 +48,7 @@ export const chainToSegments = (chain: RouteChain): string[] | null => {
   for (const route of chain) {
     for (const segment of route.segments) {
       if (segment[0] === ':') {
+        // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
         const param = route.params && route.params[segment.slice(1)];
         if (!param) {
           return null;

core/src/components/router/utils/path.ts

@@ -96,6 +96,7 @@ const HapticEngine = {
      * if the browser does not support the Vibrate API.
      */
     if (capacitor?.getPlatform() === 'web') {
+      // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
       return typeof navigator !== 'undefined' && navigator.vibrate !== undefined;
     }
 

core/src/utils/native/haptic.ts

@@ -95,6 +95,7 @@ export const createOverlay = <T extends HTMLIonOverlayElement>(
   tagName: string,
   opts: object | undefined
 ): Promise<T> => {
+  // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
   if (typeof window !== 'undefined' && typeof window.customElements !== 'undefined') {
     return window.customElements.whenDefined(tagName).then(() => {
       const element = document.createElement(tagName) as HTMLIonOverlayElement;

core/src/utils/overlays.ts

@@ -294,6 +294,7 @@ export const iosTransitionAnimation = (navEl: HTMLElement, opts: TransitionOptio
       .fill('both')
       .beforeRemoveClass('ion-page-invisible');
 
+    // eslint-disable-next-line @typescript-eslint/prefer-optional-chain
     if (leavingEl && navEl !== null && navEl !== undefined) {
       const navDecorAnimation = createAnimation();
       navDecorAnimation.addElement(navEl);

core/src/utils/transition/ios.transition.ts

@@ -14,7 +14,8 @@
       "dom",
       "dom.iterable",
       "es2017",
-      "es2020"
+      "es2020",
+      "es2021"
     ],
     "module": "esnext",
     "moduleResolution": "node",