Skip to content

Commit d62ddbd

Browse files
address CR comments
1 parent 1885088 commit d62ddbd

File tree

2 files changed

+10
-5
lines changed

2 files changed

+10
-5
lines changed

core/src/components/badge/badge.ionic.scss

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
// --------------------------------------------------
66

77
:host {
8-
--padding-start: #{globals.$ion-space-050};
9-
--padding-end: #{globals.$ion-space-050};
8+
--padding-start: #{globals.$ion-space-200};
9+
--padding-end: #{globals.$ion-space-200};
1010
--padding-top: #{globals.$ion-space-0};
1111
--padding-bottom: #{globals.$ion-space-0};
1212

@@ -73,6 +73,9 @@
7373

7474
/* Small Badge */
7575
:host(.badge-small) {
76+
--padding-start: #{globals.$ion-space-050};
77+
--padding-end: #{globals.$ion-space-050};
78+
7679
min-width: globals.$ion-scale-400;
7780
height: globals.$ion-scale-400;
7881
}
@@ -83,7 +86,9 @@
8386
}
8487

8588
/* Medium Badge */
86-
:host(.badge-medium) {
89+
/* Large size defaults to the medium size to avoid styles breakage */
90+
:host(.badge-medium),
91+
:host(.badge-large) {
8792
--padding-start: #{globals.$ion-space-100};
8893
--padding-end: #{globals.$ion-space-100};
8994

@@ -93,7 +98,8 @@
9398
height: globals.$ion-scale-600;
9499
}
95100

96-
:host(.badge-medium) ::slotted(ion-icon) {
101+
:host(.badge-medium) ::slotted(ion-icon),
102+
:host(.badge-large) ::slotted(ion-icon) {
97103
width: globals.$ion-scale-400;
98104
height: globals.$ion-scale-400;
99105
}

core/src/components/badge/test/shape/badge.e2e.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ configs({ directions: ['ltr'], modes: ['ionic-md'] }).forEach(({ config, screens
5858
`
5959
<div id="container">
6060
<ion-badge shape="soft" size="medium">1</ion-badge>
61-
<ion-badge shape="soft" size="large">1</ion-badge>
6261
</div>
6362
`,
6463
config

0 commit comments

Comments
 (0)