Skip to content

Commit d685d09

Browse files
joselrioIonitron
andauthored
fix(select): add missing filled type styles (#30763)
Issue number: resolves # --------- This is based on #30755 PR to try to clean up things. <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? - Select text color was not according design - Fill solid type was missing the background color ## What is the new behavior? - Added the expected color to the select text - Added missing background color variable to the fill solid type ## Does this introduce a breaking change? - [ ] Yes - [X] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> --------- Co-authored-by: ionitron <[email protected]>
1 parent 28caeff commit d685d09

File tree

83 files changed

+19
-4
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

83 files changed

+19
-4
lines changed

core/src/components/select/select.ionic.scss

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,12 @@
3838

3939
.select-text {
4040
min-width: globals.$ion-space-400;
41+
42+
color: globals.$ion-text-subtlest;
43+
}
44+
45+
:host(.has-value) .select-text {
46+
color: globals.$ion-text-default;
4147
}
4248

4349
// Select Label
@@ -208,6 +214,12 @@
208214

209215
.select-icon {
210216
transition: transform 0.15s globals.$ion-transition-curve-expressive;
217+
218+
color: globals.$ion-text-subtlest;
219+
}
220+
221+
:host(.has-value) .select-icon {
222+
color: globals.$ion-text-subtle;
211223
}
212224

213225
/**
@@ -219,13 +231,15 @@
219231
@include globals.transform(rotate(180deg));
220232
}
221233

222-
.select-icon {
223-
color: globals.$ion-primitives-neutral-800;
224-
}
225-
226234
// States
227235
// ----------------------------------------------------------------
228236

237+
// Fill types
238+
// ----------------------------------------------------------------
239+
:host(.select-fill-solid) {
240+
--background: #{globals.$ion-bg-input-bold-default};
241+
}
242+
229243
// Disabled
230244
// ---------------------------------------------
231245

-205 Bytes
14 Bytes
78 Bytes

core/src/components/select/test/custom/select.e2e.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ configs({ modes: ['ios', 'md', 'ionic-md'], directions: ['ltr'] }).forEach(({ ti
5757
</div>
5858
5959
<style>
60+
ion-select::part(text),
6061
ion-select::part(container) {
6162
color: purple;
6263
}
-133 Bytes
-124 Bytes
-8 Bytes

0 commit comments

Comments
 (0)