You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue number: resolvesionic-team/ionic-docs#4145
---------
## What is the current behavior?
Some component methods are missing param tags in the JSDoc comments.
Some comments are out of order and the method description is below the
last param description. Some back ticks are misplaced around words
resulting in incorrect formatting in the docs site.
## What is the new behavior?
Method documentation in app, action-sheet, alert, datetime, loading,
menu, modal, popover, reorder-group, router, searchbar, and toast now
include descriptions for all params, all method descriptions are placed
above param descriptions, and back ticks are formatted correctly. All
changes are within JSDoc comments so will result in a change to the docs
site but no functional change to any components.
## Does this introduce a breaking change?
- [ ] Yes
- [x] No
## Other information
In order to preview these changes I took the JSON generated from the
build on this branch and used it in the docusaurus script in place of
the fetch from unpkg. I set up a preview from my fork on Vercel -
https://ionic-docs-git-temptotestdocs-soundproofboots-projects.vercel.app/docs/components
. The change I made to the docusaurus script to use this temp data is
here - https://github.com/soundproofboot/ionic-docs/pull/1/files.
tempDocs.json is the output of the framework build after making these
changes.
---------
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Maria Hutt <[email protected]>
Copy file name to clipboardExpand all lines: core/src/components/datetime/datetime.tsx
+6Lines changed: 6 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -524,6 +524,8 @@ export class Datetime implements ComponentInterface {
524
524
* Confirms the selected datetime value, updates the
525
525
* `value` property, and optionally closes the popover
526
526
* or modal that the datetime was presented in.
527
+
*
528
+
* @param closeOverlay If `true`, closes the parent overlay. Defaults to `false`.
527
529
*/
528
530
@Method()
529
531
asyncconfirm(closeOverlay=false){
@@ -559,6 +561,8 @@ export class Datetime implements ComponentInterface {
559
561
* Resets the internal state of the datetime but does not update the value.
560
562
* Passing a valid ISO-8601 string will reset the state of the component to the provided date.
561
563
* If no value is provided, the internal state will be reset to the clamped value of the min, max and today.
564
+
*
565
+
* @param startDate A valid [ISO-8601 string](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date#date_time_string_format) to reset the datetime state to.
562
566
*/
563
567
@Method()
564
568
asyncreset(startDate?: string){
@@ -570,6 +574,8 @@ export class Datetime implements ComponentInterface {
570
574
* optionally closes the popover
571
575
* or modal that the datetime was
572
576
* presented in.
577
+
*
578
+
* @param closeOverlay If `true`, closes the parent overlay. Defaults to `false`.
0 commit comments