Skip to content

Commit dd93e0b

Browse files
authored
fix(angular): export missing lifecycle interfaces for standalone package (#28346)
Issue number: N/A Resolves feedback identified here: https://github.com/ionic-team/ionic-angular-standalone-codemods/pull/13/files/baa37ef1e3e8ba773b693db280542efba815482a#r1356414362 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The lifecycle interfaces are not exported from `@ionic/angular/standalone`. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Lifecycle interfaces are exported from `@ionic/angular/standalone`. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. -->
1 parent 79725d7 commit dd93e0b

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

packages/angular/common/src/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ export { Platform } from './providers/platform';
1818
export { bindLifecycleEvents, AngularDelegate } from './providers/angular-delegate';
1919

2020
export type { IonicWindow } from './types/interfaces';
21+
export type { ViewWillEnter, ViewWillLeave, ViewDidEnter, ViewDidLeave } from './types/ionic-lifecycle-hooks';
2122

2223
export { NavParams } from './directives/navigation/nav-params';
2324

packages/angular/src/index.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,12 @@ export {
3737
AngularDelegate,
3838
NavParams,
3939
IonicRouteStrategy,
40+
ViewWillEnter,
41+
ViewWillLeave,
42+
ViewDidEnter,
43+
ViewDidLeave,
4044
} from '@ionic/angular/common';
4145

42-
// TYPES
43-
export * from './types/ionic-lifecycle-hooks';
44-
4546
// PACKAGE MODULE
4647
export { IonicModule } from './ionic-module';
4748

packages/angular/standalone/src/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ export {
2222
Platform,
2323
NavParams,
2424
IonicRouteStrategy,
25+
ViewWillEnter,
26+
ViewDidEnter,
27+
ViewWillLeave,
28+
ViewDidLeave,
2529
} from '@ionic/angular/common';
2630
export { IonNav } from './navigation/nav';
2731
export {

0 commit comments

Comments
 (0)