Skip to content

Commit df945f5

Browse files
committed
define children explicitly in more places
1 parent 484f247 commit df945f5

File tree

5 files changed

+5
-0
lines changed

5 files changed

+5
-0
lines changed

packages/react/src/components/createControllerComponent.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ interface OverlayBase extends HTMLElement {
1010

1111
export interface ReactControllerProps {
1212
isOpen: boolean;
13+
children?: React.ReactNode;
1314
onDidDismiss?: (event: CustomEvent<OverlayEventDetail>) => void;
1415
onDidPresent?: (event: CustomEvent<OverlayEventDetail>) => void;
1516
onWillDismiss?: (event: CustomEvent<OverlayEventDetail>) => void;

packages/react/src/components/navigation/IonNav.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ const IonNavInner = createReactComponent<JSX.IonNav & { delegate: FrameworkDeleg
1414
);
1515

1616
type IonNavProps = JSX.IonNav & {
17+
children?: React.ReactNode;
1718
forwardedRef?: React.ForwardedRef<HTMLIonNavElement>;
1819
};
1920

packages/react/src/routing/NavManager.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ interface NavManagerProps {
3434
ionRoute: any;
3535
stackManager: any;
3636
locationHistory: LocationHistory;
37+
children?: React.ReactNode;
3738
}
3839

3940
export class NavManager extends React.PureComponent<NavManagerProps, NavContextState> {

packages/react/src/routing/PageManager.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { StackContext } from './StackContext';
88

99
interface PageManagerProps {
1010
className?: string;
11+
children?: React.ReactNode;
1112
forwardedRef?: React.ForwardedRef<HTMLDivElement>;
1213
routeInfo?: RouteInfo;
1314
}

packages/react/src/routing/ViewLifeCycleManager.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import { DefaultIonLifeCycleContext, IonLifeCycleContext } from '../contexts/Ion
55
interface ViewTransitionManagerProps {
66
removeView: () => void;
77
mount: boolean;
8+
children?: React.ReactNode;
89
}
910

1011
interface ViewTransitionManagerState {

0 commit comments

Comments
 (0)