Skip to content

Commit e411078

Browse files
committed
Updating tests to not use pull and push
1 parent 306eea9 commit e411078

File tree

1 file changed

+18
-15
lines changed

1 file changed

+18
-15
lines changed

core/src/components/grid/test/offsets/index.html

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,37 +23,37 @@
2323
</ion-header>
2424

2525
<ion-content id="content" class="grid-demo">
26-
<h2 class="ion-padding-start">Push</h2>
26+
<h2 class="ion-padding-start">Offset</h2>
2727
<ion-grid>
2828
<ion-row>
29-
<ion-col size="auto" push="1">
30-
<div>ion-col push 1</div>
29+
<ion-col size="auto" offset="1">
30+
<div>ion-col offset 1</div>
3131
</ion-col>
32-
<ion-col size="auto" push="1">
33-
<div>ion-col push 1</div>
32+
<ion-col size="auto" offset="0">
33+
<div>ion-col offset 0</div>
3434
</ion-col>
3535
</ion-row>
3636
</ion-grid>
3737

38-
<h2 class="ion-padding-start">Push and Pull</h2>
38+
<h2 class="ion-padding-start">Order</h2>
3939
<ion-grid>
4040
<ion-row>
41-
<ion-col size="9" push="3">
42-
<div>ion-col push 3</div>
41+
<ion-col size="9" order="2">
42+
<div>ion-col order 2</div>
4343
</ion-col>
44-
<ion-col size="3" pull="9">
45-
<div>ion-col pull 9</div>
44+
<ion-col size="3" order="1">
45+
<div>ion-col order 1</div>
4646
</ion-col>
4747
</ion-row>
4848
</ion-grid>
4949

5050
<ion-grid>
5151
<ion-row>
52-
<ion-col size="3" size-md="6" push="9" push-md="6">
53-
<div>ion-col size="3" size-md="6" push="9" push-md="6"</div>
52+
<ion-col size="3" size-md="6" order="2" order-md="1">
53+
<div>ion-col size="3" size-md="6" order="2" order-md="1"</div>
5454
</ion-col>
55-
<ion-col size="9" size-md="6" pull="3" pull-md="6">
56-
<div>ion-col size="9" size-md="6" pull="3" pull-md="6"</div>
55+
<ion-col size="9" size-md="6" order="1" order-md="2">
56+
<div>ion-col size="9" size-md="6" order="1" order-md="2"</div>
5757
</ion-col>
5858
</ion-row>
5959
</ion-grid>
@@ -70,6 +70,7 @@ <h2 class="ion-padding-start">Offset</h2>
7070
</ion-row>
7171
</ion-grid>
7272

73+
<h2 class="ion-padding-start">Dynamic Offset</h2>
7374
<ion-grid>
7475
<ion-row>
7576
<ion-col id="dynamicOffsetCol" offset="2" offset-md="5">
@@ -88,8 +89,10 @@ <h2 class="ion-padding-start">Offset</h2>
8889
function updateOffset() {
8990
var dynamicOffsetCol = document.getElementById('dynamicOffsetCol');
9091
var currentOffset = dynamicOffsetCol.offset;
92+
var currentOffsetMd = dynamicOffsetCol.offsetMd;
9193
dynamicOffsetCol.offset = currentOffset === '2' ? '4' : '2';
92-
console.log('Updating offset from ' + currentOffset + ' to ' + dynamicOffsetCol.offset);
94+
dynamicOffsetCol.offsetMd = currentOffsetMd === '5' ? '2' : '5';
95+
console.log(`Updating offset from ${currentOffset} to ${dynamicOffsetCol.offset} and offset-md from ${currentOffsetMd} to ${dynamicOffsetCol.offsetMd}`);
9396
}
9497
</script>
9598

0 commit comments

Comments
 (0)