Skip to content

Commit e9f211b

Browse files
committed
fix(rippl-effect): prevent memory leak when removing element
1 parent 295fa00 commit e9f211b

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

core/src/components/ripple-effect/ripple-effect.tsx

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,16 @@ export class RippleEffect implements ComponentInterface {
9292
}
9393

9494
const removeRipple = (ripple: HTMLElement) => {
95+
if (!ripple.parentNode) return;
9596
ripple.classList.add('fade-out');
96-
setTimeout(() => {
97-
ripple.remove();
98-
}, 200);
97+
98+
ripple.addEventListener(
99+
'transitionend',
100+
() => {
101+
ripple.remove();
102+
},
103+
{ once: true }
104+
);
99105
};
100106

101107
const PADDING = 10;

0 commit comments

Comments
 (0)