Skip to content

Commit eb3c5a9

Browse files
committed
test(toast): skip high constrast for now
1 parent 161b46a commit eb3c5a9

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

core/src/components/toast/test/a11y/toast.e2e.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,8 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
236236
*/
237237
configs({ directions: ['ltr'], palettes: ['high-contrast-dark', 'high-contrast'] }).forEach(
238238
({ title, config, screenshot }) => {
239-
test.describe(title('toast: high contrast: buttons'), () => {
239+
// TODO(FW-4005): Once high contrast themes are fully implemented in ionic modular, remove the skips from these tests
240+
test.describe.skip(title('toast: high contrast: buttons'), () => {
240241
test.beforeEach(async ({ page }) => {
241242
await page.setContent(
242243
`

core/src/css/palettes/high-contrast-dark.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ $lightest-text-color: $text-color;
178178
--ion-background-color-rgb: #{color-to-rgb-list($background-color)};
179179
--ion-text-color: #{$text-color};
180180
--ion-text-color-rgb: #{color-to-rgb-list($text-color)};
181-
// TODO(FW-4005): Implement these to ionic modular
181+
// TODO(FW-4005): Implement the following components to the high contrast dark theme in ionic modular
182182
--ion-border-color: #222222;
183183
--ion-item-background: #1e1e1e;
184184
--ion-toolbar-background: #1f1f1f;
@@ -224,7 +224,7 @@ $lightest-text-color: $text-color;
224224
--ion-background-color-step-950: #{mix($text-color, $background-color, 95%)};
225225
}
226226

227-
// TODO(FW-4005): Implement these to ionic modular
227+
// TODO(FW-4005): Implement the following to the high contrast dark theme in ionic modular
228228
// Toast
229229
// --------------------------------------------------
230230

core/src/css/palettes/high-contrast.scss

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,16 +105,14 @@ $lightest-text-color: #888888;
105105
--ion-text-color: #{$text-color};
106106
--ion-text-color-rgb: #{color-to-rgb-list($text-color)};
107107

108-
// TODO(FW-4005): Implement these to ionic modular
108+
// TODO(FW-4005): Implement the following to the high contrast theme in ionic modular
109109
--ion-placeholder-opacity: 0.8;
110110

111-
// TODO(FW-4005): Implement these to ionic modular
111+
// TODO(FW-4005): Implement the following to the high contrast theme in ionic modular
112112
/// Only the item borders should increase in contrast
113113
/// Borders for elements like toolbars should remain the same
114114
--ion-item-border-color: #7a7a7a;
115115

116-
// $lightest-text-color: #888888;
117-
// $darkest-text-color: #000000;
118116
--ion-text-color-step-50: #{mix($lightest-text-color, $darkest-text-color, 5%)};
119117
--ion-text-color-step-100: #{mix($lightest-text-color, $darkest-text-color, 10%)};
120118
--ion-text-color-step-150: #{mix($lightest-text-color, $darkest-text-color, 15%)};
@@ -147,7 +145,7 @@ $lightest-text-color: #888888;
147145
}
148146
}
149147

150-
// TODO(FW-4005): Implement these to ionic modular
148+
// TODO(FW-4005): Implement the following to the high contrast theme in ionic modular
151149
@mixin high-contrast-light-md-palette() {
152150
// Toast
153151
// --------------------------------------------------

0 commit comments

Comments
 (0)