Skip to content

Commit f5bb210

Browse files
committed
test(themes): remove outdated test and
1 parent e00a7b3 commit f5bb210

File tree

2 files changed

+4
-36
lines changed

2 files changed

+4
-36
lines changed

core/src/themes/native/test/colors/index.html

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -328,12 +328,10 @@ <h3 class="header">Background 16%</h3>
328328
});
329329

330330
function togglePalette(palette) {
331-
let cssFile = `/css/palettes/${palette}.always.css`;
332-
if (palette === 'default') {
333-
// TODO FW-5862 update this to not
334-
// load a file when default is set. The light
335-
// palette is automatically set when importing ionic.bundle.css
336-
cssFile = `/src/themes/test/default.css`;
331+
let cssFile = '';
332+
333+
if (palette === 'dark') {
334+
cssFile = `/css/palettes/${palette}.always.css`;
337335
}
338336

339337
var oldLink = document.getElementById('palette');

core/src/themes/native/test/colors/theme.e2e.ts

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -230,36 +230,6 @@ configs({ modes: ['md'], directions: ['ltr'], palettes: ['high-contrast', 'high-
230230

231231
configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ config, title }) => {
232232
test.describe(title('colors: custom'), () => {
233-
// TODO(): this test can be removed when foreground is a required variant
234-
// for ios and md themes
235-
test(`overriding secondary color without foreground variant should style text properly`, async ({ page }) => {
236-
await page.setContent(
237-
`${styleTestHelpers}
238-
239-
<style>
240-
:root {
241-
--ion-color-secondary: #ff6c52;
242-
--ion-color-secondary-rgb: 255,108,82;
243-
--ion-color-secondary-contrast: #000000;
244-
--ion-color-secondary-contrast-rgb: 0,0,0;
245-
--ion-color-secondary-shade: #e05f48;
246-
--ion-color-secondary-tint: #ff7b63;
247-
}
248-
</style>
249-
250-
<main class="ion-color-secondary">
251-
<p class="ion-color">Hello World</p>
252-
</main>`,
253-
config
254-
);
255-
256-
const paragraph = await page.locator('p');
257-
const color = await paragraph.evaluate((el) => getComputedStyle(el).color);
258-
259-
// Ensure the color matches --ion-color-secondary
260-
expect(color).toBe('rgb(255, 108, 82)');
261-
});
262-
263233
test(`overriding secondary color with foreground variant should style text properly`, async ({ page }) => {
264234
await page.setContent(
265235
`${styleTestHelpers}

0 commit comments

Comments
 (0)