Skip to content

Commit ff0d215

Browse files
committed
style: document the requirement to remove the ion-hide class
1 parent 5aa6551 commit ff0d215

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

core/src/components/back-button/test/basic/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ <h3>Custom</h3>
125125

126126
<ion-toolbar color="dark">
127127
<ion-buttons slot="start">
128-
<ion-back-button class="ion-hide"></ion-back-button>
128+
<ion-back-button class="ion-display-none"></ion-back-button>
129129
</ion-buttons>
130130
<ion-title>Hidden</ion-title>
131131
</ion-toolbar>

core/src/components/progress-bar/progress-bar.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ const renderProgress = (value: number, buffer: number) => {
107107
* When finalBuffer === 1, we use display: none
108108
* instead of removing the element to avoid flickering.
109109
*/
110+
// TODO(FW-6697): change `ion-hide` class to `ion-display-none` or another class
110111
<div
111112
class={{ 'buffer-circles-container': true, 'ion-hide': finalBuffer === 1 }}
112113
style={{ transform: `translateX(${finalBuffer * 100}%)` }}

0 commit comments

Comments
 (0)