Skip to content

feat(segment): add default styles for ionic theme #29897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 2, 2024
Merged

feat(segment): add default styles for ionic theme #29897

merged 18 commits into from
Oct 2, 2024

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Sep 26, 2024 •
edited
Loading

Issue number: internal

What is the current behavior?

The segment component does not have styles for the "ionic" theme and uses "md" styles.

What is the new behavior?

  • Adds styles for both <ion-segment> and <ion-segment-button> styles for the "ionic" theme
  • Adds screenshot tests for the different icon layouts

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 3:29pm

@github-actions github-actions bot added the package: core @ionic/core package label Sep 26, 2024
@brandyscarney brandyscarney marked this pull request as ready for review September 27, 2024 19:14
@brandyscarney brandyscarney requested a review from a team as a code owner September 27, 2024 19:14
thetaPC
thetaPC reviewed Sep 30, 2024
View reviewed changes
thetaPC
thetaPC approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tanner-reits
tanner-reits approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney brandyscarney merged commit 61876a5 into next Oct 2, 2024
46 checks passed
@brandyscarney brandyscarney deleted the ROU-10973 branch October 2, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC approved these changes

+1 more reviewer

@tanner-reits tanner-reits tanner-reits approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandyscarney @thetaPC @tanner-reits