refactor(searchbar): update default styles for ionic theme #29917
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| await expect(searchbar).toHaveScreenshot(screenshot(`searchbar-color`)); | ||
| }); | ||
|
|
||
| test('should render disabled searchbar', async ({ page }) => { |
There was a problem hiding this comment.
Moved this to the states test folder.
There was a problem hiding this comment.
Actually do we need this file since we are already using tokens?
There was a problem hiding this comment.
I added this file because I wanted the padding logic separate so it would be easier to read. Plus, if one of them changes like gap then the dev wouldn't have to worry about updating padding start or end. Thoughts?
There was a problem hiding this comment.
I don’t feel strongly about this, but I believe we wanted to avoid creating var files for the Ionic theme since we already have tokens. @BenOsodrac do you have any thoughts on this?
There was a problem hiding this comment.
I ended up removing the file and added comments: 739abe1
...asic/searchbar.e2e.ts-snapshots/searchbar-buttons-ionic-md-rtl-light-Mobile-Chrome-linux.png
Show resolved
Hide resolved
Issue number: internal
What is the current behavior?
Ionic theme: Searchbar does not match design.
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview