Skip to content

fix(overlays): do not hide root when toast appears #29962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix(overlays): do not hide root when toast appears #29962

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5bd24e
fix(overlays): do not hide root when toast appears
thetaPC Oct 23, 2024
33be9ff
chore: run lint
thetaPC Oct 23, 2024
ea28919
fix(overlays): remove aria hidden if last overlay is not toast
thetaPC Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/src/utils/overlays.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,16 @@ export const present = async <OverlayPresentOptions>(
return;
}

setRootAriaHidden(true);
/**
* Due to accessibility guidelines, toasts do not have
* focus traps.
*
* All other overlays should have focus traps to prevent
* the keyboard focus from leaving the overlay.
*/
if (overlay.el.tagName !== 'ION-TOAST') {
setRootAriaHidden(true);
}

document.body.classList.add(BACKDROP_NO_SCROLL);

Expand Down
Loading