Skip to content

fix(overlays): hide the focus trap div from screen readers #29970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix(overlays): hide the focus trap div from screen readers #29970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/components/action-sheet/action-sheet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
>
<ion-backdrop tappable={this.backdropDismiss} />

<div tabindex="0"></div>
<div tabindex="0" aria-hidden="true"></div>

<div class="action-sheet-wrapper ion-overlay-wrapper" ref={(el) => (this.wrapperEl = el)}>
<div class="action-sheet-container">
Expand Down Expand Up @@ -446,7 +446,7 @@ export class ActionSheet implements ComponentInterface, OverlayInterface {
</div>
</div>

<div tabindex="0"></div>
<div tabindex="0" aria-hidden="true"></div>
</Host>
);
}
Expand Down
4 changes: 2 additions & 2 deletions core/src/components/alert/alert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
>
<ion-backdrop tappable={this.backdropDismiss} />

<div tabindex="0"></div>
<div tabindex="0" aria-hidden="true"></div>

<div class="alert-wrapper ion-overlay-wrapper" ref={(el) => (this.wrapperEl = el)}>
<div class="alert-head">
Expand All @@ -779,7 +779,7 @@ export class Alert implements ComponentInterface, OverlayInterface {
{this.renderAlertButtons()}
</div>

<div tabindex="0"></div>
<div tabindex="0" aria-hidden="true"></div>
</Host>
);
}
Expand Down
4 changes: 2 additions & 2 deletions core/src/components/loading/loading.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ export class Loading implements ComponentInterface, OverlayInterface {
>
<ion-backdrop visible={this.showBackdrop} tappable={this.backdropDismiss} />

<div tabindex="0"></div>
<div tabindex="0" aria-hidden="true"></div>

<div class="loading-wrapper ion-overlay-wrapper">
{spinner && (
Expand All @@ -368,7 +368,7 @@ export class Loading implements ComponentInterface, OverlayInterface {
{message !== undefined && this.renderLoadingMessage(msgId)}
</div>

<div tabindex="0"></div>
<div tabindex="0" aria-hidden="true"></div>
</Host>
);
}
Expand Down
4 changes: 2 additions & 2 deletions core/src/components/picker-legacy/picker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export class Picker implements ComponentInterface, OverlayInterface {
>
<ion-backdrop visible={this.showBackdrop} tappable={this.backdropDismiss}></ion-backdrop>

<div tabindex="0"></div>
<div tabindex="0" aria-hidden="true"></div>

<div class="picker-wrapper ion-overlay-wrapper" role="dialog">
<div class="picker-toolbar">
Expand All @@ -395,7 +395,7 @@ export class Picker implements ComponentInterface, OverlayInterface {
</div>
</div>

<div tabindex="0"></div>
<div tabindex="0" aria-hidden="true"></div>
</Host>
);
}
Expand Down
Loading