Skip to content

fix(select-modal): match radio styles to iOS native #30119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2025
Merged

fix(select-modal): match radio styles to iOS native #30119

merged 5 commits into from
Jan 9, 2025

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Jan 8, 2025 •
edited
Loading

Issue number: internal

What is the current behavior?

When the select-modal displays radios, a bottom border is shown under the radio icon and text. However, native iOS does not have the border under the icon.

What is the new behavior?

  • The bottom border is displayed under the radio text only.
  • The ion-item within select-modal has been given the prop of lines="none" since border styling has been done through select-md.ios.scss and because md doesn't use it.
  • Updated snapshots

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview (iOS)
Preview (md)

@vercel
Copy link

vercel bot commented Jan 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 1:04am

@github-actions github-actions bot added the package: core @ionic/core package label Jan 8, 2025
@thetaPC thetaPC marked this pull request as ready for review January 9, 2025 01:13
@thetaPC thetaPC requested a review from a team as a code owner January 9, 2025 01:13
brandyscarney
brandyscarney approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I experimented with slotting the ion-radio in the start slot and using inset lines but the click events weren't firing when clicking on the entire item. 👍

@thetaPC thetaPC added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit 3f8346e Jan 9, 2025
49 checks passed
@thetaPC thetaPC deleted the ROU-11404 branch January 9, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@tanner-reits tanner-reits Awaiting requested review from tanner-reits tanner-reits is a code owner automatically assigned from ionic-team/framework

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thetaPC @brandyscarney