Skip to content

fix(capacitor): replace deprecated platform check method #30195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2025
Merged

fix(capacitor): replace deprecated platform check method #30195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbd3a9f
replace deprecated method
r-yanyo Feb 17, 2025
e05865c
fix(test): fixing mock for native platform check to support new capac…
ShaneK Feb 28, 2025
a9c20af
fix(capacitor): fixing capacitor 2 support
ShaneK Feb 28, 2025
8899f9b
fix(capacitor): reference todo ticket, fix boolean conversion
ShaneK Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/src/utils/platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ const isCordova = (win: any): boolean => !!(win['cordova'] || win['phonegap'] ||

const isCapacitorNative = (win: any): boolean => {
const capacitor = win['Capacitor'];
return !!capacitor?.isNative;
// TODO(ROU-11693): Remove when we no longer support Capacitor 2, which does not have isNativePlatform
return !!(capacitor?.isNative || (capacitor?.isNativePlatform && !!capacitor.isNativePlatform()));
};

const isElectron = (win: Window): boolean => testUserAgent(win, /electron/i);
Expand Down
2 changes: 1 addition & 1 deletion core/src/utils/test/platform.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const PlatformConfiguration = {
},
Capacitor: {
Capacitor: {
isNative: true,
isNativePlatform: () => true,
},
},
PWA: {
Expand Down
Loading