feat(searchbar): add sizes for ionic theme #30211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
package: angular
thetaPC
commented
Feb 25, 2025
Comment on lines
120
to
126
| // Searchbar in Toolbar | ||
| // ----------------------------------------- | ||
|
|
||
| :host-context(ion-toolbar) { | ||
| min-height: globals.$ion-scale-1200; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Removed because it doesn't seem to be used.
thetaPC
requested review from
OS-pedrolourenco,
brandyscarney and
rugoncalves
and removed request for
rugoncalves
Comment on lines
31
to
32
| width: globals.$ion-scale-500; | ||
| height: globals.$ion-scale-500; |
Member
There was a problem hiding this comment.
The Figma design for this shows it should be scale-400 but actually uses scale-500. Have we asked design to clarify this?
JoaoFerreira-FrontEnd
approved these changes
Feb 27, 2025
ShaneK
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Searchbar does not have sizes.
What is the new behavior?
ionictheme:medium,largeionictheme defaults tomediumiosandmdtheme defaults to undefinedDoes this introduce a breaking change?
Other information
Preview: size
Preview: within toolbar