-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(badge): add support for number and icons with vertical prop #30305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
f77ca7f
0aab47b
0e07a99
693e6d2
03b223f
ea78288
2cf9bd2
3304502
522b0fe
efdd0fe
76f94fc
ba3cf9c
a9e337d
9eac519
290c9e4
e764fa5
d12c8cb
2d4b488
96bd044
760d71a
6369bca
76e90e0
f13bd08
1414ee7
68a42a8
3d93428
6be2877
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -26,3 +26,9 @@ $badge-font-size: dynamic-font($badge-baseline-font-size); | |||
|
|
||||
| /// @prop - Font weight of the badge | ||||
| $badge-font-weight: bold; | ||||
|
|
||||
| /// @prop - Font size of the badge hint | ||||
| $badge-hint-baseline-font-size: 8px; | ||||
|
||||
|
|
||||
| /// @prop - Font size of the badge hint | ||||
| $badge-hint-font-size: dynamic-font($badge-hint-baseline-font-size); | ||||
|
||||
| $badge-hint-font-size: dynamic-font($badge-hint-baseline-font-size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be use don the badge.native.scss, but I wrongly used the $badge-hint-baseline-font-size there instead. Already fixed it.
I followed the same approach as the font-size vars arlready defined on that vars file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are for native usage only, create a badge.native.vars.scss file and move those tokens there. That way ionic isn't importing extra weight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Uh oh!
There was an error while loading. Please reload this page.