-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(datetime): fix height when presentation='time' #30416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
78c5c45
feat(datetime): fix height when presentation='time'
OS-giulianasilva 28e3138
chore(): add updated snapshots
Ionitron eb95c0e
test(typography): update snapshot
OS-giulianasilva 51047ee
Merge branch 'ROU-11932' of https://github.com/ionic-team/ionic-frame…
OS-giulianasilva 763dbb3
test(typography): remove snapshots
OS-giulianasilva 0989ef9
chore(): add updated snapshots
Ionitron e0b11fa
feat(datetime): set display tests to run for the ionic theme
OS-giulianasilva a00560d
Merge branch 'ROU-11932' of https://github.com/ionic-team/ionic-frame…
OS-giulianasilva 80f9317
chore(): add updated snapshots
Ionitron fba7114
test(typography): remove snapshots
OS-giulianasilva dcfc202
Merge branch 'ROU-11932' of https://github.com/ionic-team/ionic-frame…
OS-giulianasilva 6849dc6
chore(): add updated snapshots
Ionitron 9d5150f
feat(datetime): fix time button's height
OS-giulianasilva 4295282
Merge branch 'ROU-11932' of https://github.com/ionic-team/ionic-frame…
OS-giulianasilva 98b844e
lint
OS-giulianasilva cc0afbf
chore(): add updated snapshots
Ionitron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-93 Bytes
(100%)
...apshots/datetime-basic-default-title-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-159 Bytes
(99%)
...pshots/datetime-basic-default-title-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-128 Bytes
(99%)
...apshots/datetime-basic-default-title-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-122 Bytes
(99%)
...time.e2e.ts-snapshots/datetime-basic-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-159 Bytes
(99%)
...ime.e2e.ts-snapshots/datetime-basic-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-153 Bytes
(99%)
...time.e2e.ts-snapshots/datetime-basic-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-96 Bytes
(99%)
...apshots/datetime-footer-clear-button-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-170 Bytes
(99%)
...pshots/datetime-footer-clear-button-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-133 Bytes
(99%)
...apshots/datetime-footer-clear-button-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-99 Bytes
(99%)
...apshots/datetime-footer-clear-button-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-161 Bytes
(99%)
...pshots/datetime-footer-clear-button-ionic-md-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-143 Bytes
(99%)
...apshots/datetime-footer-clear-button-ionic-md-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-95 Bytes
(99%)
...shots/datetime-footer-custom-buttons-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-167 Bytes
(99%)
...hots/datetime-footer-custom-buttons-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-136 Bytes
(99%)
...shots/datetime-footer-custom-buttons-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-101 Bytes
(99%)
...shots/datetime-footer-custom-buttons-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-161 Bytes
(99%)
...hots/datetime-footer-custom-buttons-ionic-md-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-143 Bytes
(99%)
...shots/datetime-footer-custom-buttons-ionic-md-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-102 Bytes
(99%)
...hots/datetime-footer-default-buttons-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-154 Bytes
(99%)
...ots/datetime-footer-default-buttons-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-137 Bytes
(99%)
...hots/datetime-footer-default-buttons-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-98 Bytes
(99%)
...hots/datetime-footer-default-buttons-ionic-md-rtl-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-179 Bytes
(99%)
...ots/datetime-footer-default-buttons-ionic-md-rtl-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-137 Bytes
(99%)
...hots/datetime-footer-default-buttons-ionic-md-rtl-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-100 Bytes
(100%)
...atetime-footer-default-clear-buttons-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-163 Bytes
(99%)
...tetime-footer-default-clear-buttons-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-137 Bytes
(99%)
...atetime-footer-default-clear-buttons-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file modified
BIN
-102 Bytes
(100%)
...atetime-footer-default-clear-buttons-ionic-md-rtl-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file modified
BIN
-178 Bytes
(99%)
...tetime-footer-default-clear-buttons-ionic-md-rtl-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file modified
BIN
-141 Bytes
(99%)
...atetime-footer-default-clear-buttons-ionic-md-rtl-light-Mobile-Safari-linux.png
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+14.1 KB
...napshots/datetime-display-cover-date-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+18.5 KB
...apshots/datetime-display-cover-date-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+16.4 KB
...napshots/datetime-display-cover-date-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+16.1 KB
...ots/datetime-display-cover-date-time-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+20.8 KB
...ts/datetime-display-cover-date-time-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+18.7 KB
...ots/datetime-display-cover-date-time-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+16 KB
...ots/datetime-display-cover-time-date-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+20.8 KB
...ts/datetime-display-cover-time-date-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+18.6 KB
...ots/datetime-display-cover-time-date-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.91 KB
...napshots/datetime-display-cover-time-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+10 KB
...apshots/datetime-display-cover-time-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.52 KB
...napshots/datetime-display-cover-time-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+13.8 KB
...e.ts-snapshots/datetime-display-date-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+17.5 KB
....ts-snapshots/datetime-display-date-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+16.1 KB
...e.ts-snapshots/datetime-display-date-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+15.7 KB
...snapshots/datetime-display-date-time-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+19.7 KB
...napshots/datetime-display-date-time-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+18.3 KB
...snapshots/datetime-display-date-time-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+15.7 KB
...snapshots/datetime-display-time-date-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+19.7 KB
...napshots/datetime-display-time-date-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+18.3 KB
...snapshots/datetime-display-time-date-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.74 KB
...e.ts-snapshots/datetime-display-time-ionic-md-ltr-light-Mobile-Chrome-linux.png
Oops, something went wrong.
Binary file added
BIN
+9.48 KB
....ts-snapshots/datetime-display-time-ionic-md-ltr-light-Mobile-Firefox-linux.png
Oops, something went wrong.
Binary file added
BIN
+8.31 KB
...e.ts-snapshots/datetime-display-time-ionic-md-ltr-light-Mobile-Safari-linux.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.