Skip to content

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented May 29, 2025

Issue number: internal


What is the new behavior?

  • Review button min-width and size of icons inside.
  • Fixed test for ionic theme, with the correct medium size.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Button Ionic theme

@BenOsodrac BenOsodrac added package: core @ionic/core package type: bug a confirmed bug report labels May 29, 2025
@vercel
Copy link

vercel bot commented May 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2025 5:10pm

@BenOsodrac BenOsodrac marked this pull request as ready for review May 29, 2025 17:21
@BenOsodrac BenOsodrac requested a review from a team as a code owner May 29, 2025 17:21
@BenOsodrac BenOsodrac requested review from brandyscarney and thetaPC and removed request for thetaPC May 29, 2025 17:21
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BenOsodrac BenOsodrac merged commit 8e8e8f9 into next May 29, 2025
48 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11968-button-v2 branch May 29, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package type: bug a confirmed bug report

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants