feat(datetime): add styles for adjacent days for ionic theme #30492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ShaneK
approved these changes
Jun 17, 2025
Member
ShaneK
left a comment
ShaneK
left a comment
There was a problem hiding this comment.
This seems good to me, but odd there are no screen changes I guess. Should we add screen tests for this in the future? Or are the colors just the same?
thetaPC
requested changes
Jun 18, 2025
...ale/datetime.e2e.ts-snapshots/datetime-locale-en-US-time-diff-md-ltr-Mobile-Chrome-linux.png
Show resolved
Hide resolved
...tetime.e2e.ts-snapshots/datetime-locale-ja-JP-month-year-diff-md-ltr-Mobile-Chrome-linux.png
Show resolved
Hide resolved
Co-authored-by: Maria Hutt <[email protected]>
- remove focus of adjacent day, since adjacent days are not docusable;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the new behavior?
Now the adjacent days have proper styles for all their states.
And the next-prev month buttons have the right height.
Changes:
Does this introduce a breaking change?
Other information
ionic preview