Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

ionic-team / ionic-framework Public

Notifications You must be signed in to change notification settings
Fork 13.4k
Star 52.2k

Code
Issues 581
Pull requests 29
Discussions
Actions
Projects
Wiki
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Wiki
Security
Insights

fix(modal): dismiss modal when parent element is removed from DOM#30544

Merged

ShaneK merged 6 commits intomainionic-team/ionic-framework:mainfrom

fix/remove-modal-when-parent-removedionic-team/ionic-framework:fix/remove-modal-when-parent-removedCopy head branch name to clipboard

Jul 14, 2025

Conversation Commits6 (6)Checks Files changed

Merged

fix(modal): dismiss modal when parent element is removed from DOM#30544
ShaneK merged 6 commits intomainfrom
fix/remove-modal-when-parent-removed

Commits

Commits on Jul 12, 2025

fix(modal): dismiss modal when parent element is removed from DOM
ShaneK
committed
fix(modal): lint and test support
ShaneK
committed
refactor(modal): add early guard for MutationObserver
ShaneK
committed
fix(modal): moving mutation observer to the DOM to deal with unknown numbers of grandparents being removed, causing the modal to be removed by nothing to observe it
ShaneK
committed

Commits on Jul 13, 2025

test(modal): verifying a very depply nested modal will still be closed when a containing component is removed
ShaneK
committed
fix(modal): release cached parent when it's removed from DOM to prevent a leak
ShaneK
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.