Skip to content

test(angular): migrate to playwright #30594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 5, 2025
Merged

test(angular): migrate to playwright #30594

merged 11 commits into from
Aug 5, 2025

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Aug 2, 2025 •
edited
Loading

  • Migrates Angular test app tests from Cypress to Playwright
  • Resolves test TODOs with Angular 18
  • Resolves nav TODO by adding in standalone components
  • Updates browserslist to remove warnings

@vercel
Copy link

vercel bot commented Aug 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2025 10:53pm

@github-actions github-actions bot added the package: angular @ionic/angular package label Aug 2, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 2, 2025
View reviewed changes
@brandyscarney brandyscarney mentioned this pull request Aug 4, 2025
Merged
2 tasks
@brandyscarney brandyscarney marked this pull request as ready for review August 4, 2025 17:44
@brandyscarney brandyscarney requested a review from a team as a code owner August 4, 2025 17:44
@brandyscarney brandyscarney requested review from ShaneK and gnbm August 4, 2025 17:44
gnbm
gnbm approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @brandyscarney

ShaneK
ShaneK approved these changes Aug 5, 2025
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Generally solid upgrade 🚀

@brandyscarney brandyscarney added this pull request to the merge queue Aug 5, 2025
Merged via the queue into main with commit 05026c5 Aug 5, 2025
51 checks passed
@brandyscarney brandyscarney deleted the test/migrate-angular-playwright branch August 5, 2025 14:09
github-merge-queue bot pushed a commit that referenced this pull request Aug 5, 2025
@brandyscarney
fix(reorder-group): add children fallback for framework compatibility (…
1cd81b9 
…#30593)

Issue number: resolves #30592

---------

## What is the current behavior?
Reorder group is failing for Angular, React & Vue due to the change from
`children` to `__children`.

## What is the new behavior?
- Fallback to `children` if `__children` is undefined.
- Adds an e2e test for Angular (depends on
#30594)
- Tasks have been created to migrate and add e2e tests for the other
frameworks

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

## Other information

Dev build: `8.7.2-dev.11754087334.1815cf22`

---------

Co-authored-by: Brandy Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneK ShaneK ShaneK approved these changes

@gnbm gnbm gnbm approved these changes

Assignees

No one assigned

Labels

package: angular @ionic/angular package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brandyscarney @ShaneK @gnbm