-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(themes): add base tokens and update colors to use new token system #30692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
128a092 to
0f242f0
Compare
9ada7e1 to
7ee659c
Compare
3e1a62c to
6a3020d
Compare
be45f4a to
93d7550
Compare
…cts with the ionic theme
0e63ac9 to
d7470aa
Compare
thetaPC
reviewed
Sep 25, 2025
thetaPC
reviewed
Sep 25, 2025
thetaPC
reviewed
Sep 29, 2025
thetaPC
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ShaneK
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good! Great work!
Co-authored-by: ionitron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The colors are generated using the Sass functions and a
$colorsmap and the design tokens are undefined.What is the new behavior?
spectests into thetestdirectory with the other ones.ion-color-primary,.ion-color-secondary, etc.) which are used by the components to change their color via thecolorproperty$colorsmapDoes this introduce a breaking change?
This adds
foregroundas a required variant to the colors now. Currently foreground is only used by clear buttons but it should be used by all text-only components. This will break for any apps overriding--ion-color-primarywithout--ion-color-primary-foreground. We will have to look into improving the migration path on this later.Other information