Skip to content

Conversation

@rugoncalves
Copy link

What is the current behavior?

  • The variables when being generated from the tokens were causing the fallback to $ion-font-family to be with invalid format:
    $ion-font-family: var(
      --token-font-family,
      "-apple-system, system-ui, " Segoe UI ", Roboto, Helvetica, Arial, sans-serif, " Apple Color Emoji ", 
      " Segoe UI Emoji", " Segoe UI Symbol "",
      sans-serif
    );
    
  • Additionally the command to generate the css from the tokens, was not prepared to run on windows machines.

What is the new behavior?

  • Removed the added quotes to the variable coming from the tokens:
    $ion-font-family: var(
      --token-font-family, -apple-system, system-ui, "Segoe UI", Roboto, Helvetica, Arial, sans-serif,
      "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol"
    );
    
  • Changed the command build.tokens to run on windows
  • Generated a new version of ionic.vars.scss

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@rugoncalves rugoncalves requested a review from a team as a code owner October 1, 2025 14:16
@rugoncalves rugoncalves requested a review from thetaPC October 1, 2025 14:16
@rugoncalves rugoncalves added the package: core @ionic/core package label Oct 1, 2025
@vercel
Copy link

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Oct 1, 2025 2:16pm

Copy link
Contributor

@joselrio joselrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rugoncalves rugoncalves merged commit a350314 into next Oct 2, 2025
49 checks passed
@rugoncalves rugoncalves deleted the ROU-12241 branch October 2, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants