-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(themes): add ionic theme tokens #30708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brandyscarney
wants to merge
14
commits into
ionic-modular
Choose a base branch
from
FW-6747
base: ionic-modular
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
ionic
theme tokens are undefined.dark
palette does not work with theionic
theme.ionic
theme uses different colors thanmd
andios
.What is the new behavior?
ionic
theme currently.ionic
theme based on the existing design tokens.enabled
,rippleEffect
,formHighlight
) from the generated CSS variables.--background
and--ion-background-color
from the globalionic
theme overrides, allowing it to use the dark palette.ionic
theme, ensuring all of the themes use the same named (primary, secondary, etc.) colors.build.newTokens
, to generate the token files.Does this introduce a breaking change?
Other information
Preview: Basic
Preview: Color
Preview: Typography
Add the URL parameters
?ionic:palette=dark
or?ionic:theme={ios|md|ionic}
to see the palette or theme change and pull in the associated tokens.Note: most of the theme specific tokens are not applied yet because we haven't updated the components.