Skip to content
This repository was archived by the owner on Apr 2, 2018. It is now read-only.

Commit 28ef86c

Browse files
committed
remove unnecessary weak self references
1 parent cebfe8f commit 28ef86c

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

src/ios/IonicKeyboard.m

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ - (void)pluginInitialize
1414
__weak IonicKeyboard* weakSelf = self;
1515

1616
//set defaults
17-
weakSelf.hideKeyboardAccessoryBar = NO;
18-
weakSelf.disableScroll = NO;
17+
self.hideKeyboardAccessoryBar = NO;
18+
self.disableScroll = NO;
1919

20-
weakSelf.webView.scrollView.delegate = self;
20+
self.webView.scrollView.delegate = self;
2121

2222
_keyboardShowObserver = [nc addObserverForName:UIKeyboardWillShowNotification
2323
object:nil
@@ -46,16 +46,14 @@ - (BOOL)disableScroll
4646

4747
- (void)setDisableScroll:(BOOL)disableScroll
4848
{
49-
__weak IonicKeyboard* weakSelf = self;
50-
5149
if (disableScroll == _disableScroll) {
5250
return;
5351
}
5452
if (disableScroll){
55-
weakSelf.webView.scrollView.scrollEnabled = NO;
53+
self.webView.scrollView.scrollEnabled = NO;
5654
}
5755
else {
58-
weakSelf.webView.scrollView.scrollEnabled = YES;
56+
self.webView.scrollView.scrollEnabled = YES;
5957
}
6058

6159
_disableScroll = disableScroll;
@@ -69,16 +67,14 @@ - (BOOL)hideKeyboardAccessoryBar
6967

7068
- (void)setHideKeyboardAccessoryBar:(BOOL)hideKeyboardAccessoryBar
7169
{
72-
__weak IonicKeyboard* weakSelf = self;
73-
7470
if (hideKeyboardAccessoryBar == _hideKeyboardAccessoryBar) {
7571
return;
7672
}
7773
if (hideKeyboardAccessoryBar){
78-
weakSelf.webView.hackishlyHidesInputAccessoryView = YES;
74+
self.webView.hackishlyHidesInputAccessoryView = YES;
7975
}
8076
else {
81-
weakSelf.webView.hackishlyHidesInputAccessoryView = NO;
77+
self.webView.hackishlyHidesInputAccessoryView = NO;
8278
}
8379

8480
_hideKeyboardAccessoryBar = hideKeyboardAccessoryBar;

0 commit comments

Comments
 (0)