Skip to content

Commit 4948edc

Browse files
authored
chore: updated preset (#258)
* chore: package-lock * chore(website): bump deps, remove unnecessary, better engines * chore(website): config; remove search, update prism-react-renderer syntax * chore(website): docs; Tab -> TabItem * ci(docs): node 16 -> 18, no legacy peer deps * chore(config): add json language * chore(website): mdx 3 syntax * chore(website): add bash to prism languages
1 parent 3cfbc30 commit 4948edc

File tree

7 files changed

+4411
-2582
lines changed

7 files changed

+4411
-2582
lines changed

.github/workflows/docs-preview.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ jobs:
2929
- uses: actions/checkout@v3
3030
- uses: actions/setup-node@v3
3131
with:
32-
node-version: 16
32+
node-version: 18
3333
cache: npm
3434
cache-dependency-path: website/package-lock.json
3535
- name: Build
3636
run: |
37-
npm ci --legacy-peer-deps
37+
npm ci
3838
npm run build
3939
- uses: aws-actions/configure-aws-credentials@v1
4040
with:

.github/workflows/docs-production.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ jobs:
3131
- uses: actions/checkout@v3
3232
- uses: actions/setup-node@v3
3333
with:
34-
node-version: 16
34+
node-version: 18
3535
cache: npm
3636
cache-dependency-path: website/package-lock.json
3737
- name: Build
3838
run: |
39-
npm ci --legacy-peer-deps
39+
npm ci
4040
npm run build
4141
- uses: aws-actions/configure-aws-credentials@v1
4242
with:

website/docs/cli/commands/serve-ios.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ portals serve ios [simulator | device] \
2222
--application /path/to/your/ios.app \
2323
--dev-server http://localhost:8100
2424
```
25-
This command will present an interactive list of eligible destination since no specific device details were provided. When selected, the command will launch the iOS app to the selected device and will override all portals with the content served from the development server URL by default. If a capacitor.config.{json, ts, js} file is located in the current working directory, it will use that, otherwise it will fallback to any configuration potentially shipped in the application.
25+
This command will present an interactive list of eligible destination since no specific device details were provided. When selected, the command will launch the iOS app to the selected device and will override all portals with the content served from the development server URL by default. If a capacitor.config.{json, ts, js} file is located in the current working directory, it will use that, otherwise it will fallback to any configuration potentially shipped in the application.
2626

2727
### Examples
2828

website/docs/for-ios/how-to/use-portals-in-an-ios-library.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ values={[
1919
{ label: 'Framework', value: 'framework', },
2020
{ label: 'Package', value: 'package', },
2121
]}>
22-
<Tab value="framework">
22+
<TabItem value="framework">
2323

2424
In a framework, you need to explicitly initialize a bundle:
2525

@@ -39,9 +39,9 @@ let portal = Portal(
3939
)
4040
```
4141

42-
</Tab>
42+
</TabItem>
4343

44-
<Tab value="package">
44+
<TabItem value="package">
4545

4646
In the Portal initializer, pass `Bundle.module` to the Portal initializer:
4747

@@ -54,7 +54,7 @@ let portal = Portal(
5454
)
5555
```
5656

57-
</Tab>
57+
</TabItem>
5858

5959
</Tabs>
6060

website/docusaurus.config.js

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
const lernaConfig = require('../lerna.json');
44

5+
const { themes } = require('prism-react-renderer')
6+
57
module.exports = {
68
title: 'Ionic Portals',
79
tagline: 'Portals tagline',
@@ -24,14 +26,6 @@ module.exports = {
2426
height: 24,
2527
width: 84,
2628
},
27-
navbar: {
28-
items: [
29-
{
30-
type: 'search',
31-
position: 'left',
32-
},
33-
],
34-
},
3529
sidebar: {
3630
productDropdown: {
3731
title: 'Portals Docs',
@@ -72,9 +66,9 @@ module.exports = {
7266
respectPrefersColorScheme: true,
7367
},
7468
prism: {
75-
theme: require('prism-react-renderer/themes/github'),
76-
darkTheme: require('prism-react-renderer/themes/dracula'),
77-
additionalLanguages: ['shell-session', 'kotlin', 'groovy', 'java', 'swift', 'ruby'],
69+
theme: themes.github,
70+
darkTheme: themes.dracula,
71+
additionalLanguages: ['shell-session', 'kotlin', 'groovy', 'java', 'swift', 'ruby', 'json', 'bash'],
7872
},
7973
zoom: {
8074
selector: '.markdown em > img',

0 commit comments

Comments
 (0)