chore(ci): package-lock is updated from separate job (#1308)

Author: liamdebeasi

.github/workflows/release.yml

@@ -55,13 +55,22 @@ jobs:
       env:
         GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
       shell: bash
-    # Lerna does not automatically bump versions
-    # of Ionicons dependencies that have changed,
-    # so we do that here.
-    - name: Bump Package Lock
-      run: |
-        npx lerna exec "npm install --package-lock-only --legacy-peer-deps"
-        git add .
-        git commit -m "chore(): update package lock files"
-        git push
-      shell: bash
+
+  update-package-lock:
+    # This needs to run after finalize-release
+    # because we also push to the repo in that
+    # job. If these jobs ran in parallel then it is
+    # possible for them to push at the same time.
+    needs: [finalize-release]
+    runs-on: ubuntu-latest
+    steps:
+      # Lerna does not automatically bump versions
+      # of Ionicons dependencies that have changed,
+      # so we do that here.
+      - name: Bump Package Lock
+        run: |
+          npx lerna exec "npm install --package-lock-only --legacy-peer-deps"
+          git add .
+          git commit -m "chore(): update package lock files"
+          git push
+        shell: bash