Skip to content

Commit c57dbc5

Browse files
Merge pull request #50 from Sandipkakadiya/review
Review
2 parents c2625fd + 6ee7f97 commit c57dbc5

File tree

5 files changed

+10
-7
lines changed

5 files changed

+10
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Changelog
22

33

4-
## 1.0.0-dev.4 - 2020-01-16
4+
## 1.0.0-dev.8 - 2020-01-16
55

66
### Fixed
77
* ListTile re-implemeted.

example/pubspec.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ packages:
8080
path: ".."
8181
relative: true
8282
source: path
83-
version: "1.0.0-dev.4"
83+
version: "1.0.0-dev.8"
8484
image:
8585
dependency: transitive
8686
description:

lib/components/appbar/gf_appbar.dart

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -198,13 +198,13 @@ class GFAppBar extends StatefulWidget implements PreferredSizeWidget {
198198
assert(theme.platform != null);
199199
switch (theme.platform) {
200200
case TargetPlatform.android:
201-
case TargetPlatform.macOS:
202201
case TargetPlatform.fuchsia:
203202
return false;
204203
case TargetPlatform.iOS:
205204
return trailing == null || trailing.length < 2;
205+
default:
206+
return false;
206207
}
207-
return null;
208208
}
209209

210210
@override
@@ -290,12 +290,13 @@ class _GFAppBarState extends State<GFAppBar> {
290290
bool namesRoute;
291291
switch (theme.platform) {
292292
case TargetPlatform.android:
293-
case TargetPlatform.macOS:
294293
case TargetPlatform.fuchsia:
295294
namesRoute = true;
296295
break;
297296
case TargetPlatform.iOS:
298297
break;
298+
default:
299+
break;
299300
}
300301
title = DefaultTextStyle(
301302
style: centerStyle,

lib/components/drawer/gf_drawer.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,11 @@ class GFDrawer extends StatelessWidget {
114114
label = semanticLabel;
115115
break;
116116
case TargetPlatform.android:
117-
case TargetPlatform.macOS:
118117
case TargetPlatform.fuchsia:
119118
label = semanticLabel ?? MaterialLocalizations.of(context)?.drawerLabel;
119+
break;
120+
default:
121+
break;
120122
}
121123
return Semantics(
122124
scopesRoute: true,

pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: getflutter
22
description: GetFlutter is open source libraries that come with pre-build 1000+ UI components. It makes development faster & more enjoyable. You can customize the component as per your need.
3-
version: 1.0.0-dev.4
3+
version: 1.0.0-dev.8
44
#author: GetFlutter <[email protected]>
55
homepage: https://github.com/ionicfirebaseapp/getflutter
66

0 commit comments

Comments
 (0)