radio, radiotile, rating, sticky header changes & review

Sandip Kakadiya · Sandip Kakadiya · commit ee489ab6a1a3 · 2020-10-02T17:20:33.000+05:30
diff --git a/lib/components/checkbox/gf_checkbox.dart b/lib/components/checkbox/gf_checkbox.dart
@@ -19,7 +19,7 @@ class GFCheckbox extends StatefulWidget {
         size: 20,
         color: GFColors.WHITE,
       ),
-      this.inactiveIcon = const Icon(Icons.close),
+      this.inactiveIcon,
       this.custombgColor = GFColors.SUCCESS,
       this.autofocus = false,
       this.focusNode})
diff --git a/lib/components/checkbox_list_tile/gf_checkbox_list_tile.dart b/lib/components/checkbox_list_tile/gf_checkbox_list_tile.dart
@@ -29,7 +29,7 @@ class GFCheckboxListTile extends StatelessWidget {
       size: 20,
       color: GFColors.WHITE,
     ),
-    this.inactiveIcon = const Icon(Icons.close),
+    this.inactiveIcon,
     this.custombgColor = GFColors.SUCCESS,
     this.position = GFPosition.end,
     this.selected = false,
diff --git a/lib/components/radio/gf_radio.dart b/lib/components/radio/gf_radio.dart
@@ -23,11 +23,7 @@ class GFRadio<T> extends StatefulWidget {
         size: 20,
         color: GFColors.DARK,
       ),
-      this.inactiveIcon = const Icon(
-        Icons.close,
-        size: 20,
-        color: GFColors.DARK,
-      ),
+      this.inactiveIcon,
       this.custombgColor = GFColors.SUCCESS,
       this.autofocus = false,
       this.focusNode,
diff --git a/lib/components/radio_list_tile/gf_radio_list_tile.dart b/lib/components/radio_list_tile/gf_radio_list_tile.dart
@@ -2,6 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:getwidget/getwidget.dart';
 
 class GFRadioListTile<T> extends StatelessWidget {
+  /// [GFRadioListTile] is a list title of with [GFRadio] in it.
   const GFRadioListTile({
     Key key,
     @required this.value,
@@ -20,11 +21,7 @@ class GFRadioListTile<T> extends StatelessWidget {
       size: 20,
       color: GFColors.DARK,
     ),
-    this.inactiveIcon = const Icon(
-      Icons.close,
-      size: 20,
-      color: GFColors.DARK,
-    ),
+    this.inactiveIcon,
     this.custombgColor = GFColors.SUCCESS,
     this.autofocus = false,
     this.focusNode,
@@ -156,8 +153,7 @@ class GFRadioListTile<T> extends StatelessWidget {
   /// The value represented by this radio button.
   final T value;
 
-  /// The currently selected value for a group of radio buttons. Radio button is considered selected if its [value] matches the
-  /// [groupValue].
+  /// The currently selected value for a group of radio buttons. Radio button is considered selected if its [value] matches the [groupValue].
   final T groupValue;
 
   /// sets the radio value
@@ -168,24 +164,27 @@ class GFRadioListTile<T> extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    GFRadio radio = GFRadio(
-      autofocus: autofocus,
+    final GFRadio radio = GFRadio(
       onChanged: onChanged,
       value: value,
       groupValue: groupValue,
       size: size,
+      type: type,
+      radioColor: radioColor,
       activebgColor: activebgColor,
       inactiveIcon: inactiveIcon,
       activeBorderColor: activeBorderColor,
       inactivebgColor: inactivebgColor,
       activeIcon: activeIcon,
       inactiveBorderColor: inactiveBorderColor,
       custombgColor: custombgColor,
+      toggleable: toggleable,
     );
     return MergeSemantics(
       child: GFListTile(
         autofocus: autofocus,
         enabled: onChanged != null,
+        focusNode: focusNode,
         onTap: onChanged != null
             ? () {
                 if (toggleable && checked) {
diff --git a/lib/components/rating/gf_rating.dart b/lib/components/rating/gf_rating.dart
@@ -4,6 +4,7 @@ import 'package:getwidget/getwidget.dart';
 typedef RatingChangeCallback = void Function(double rating);
 
 class GFRating extends StatefulWidget {
+  /// [GFRating] to show ratings with many custimazation options.
   const GFRating({
     this.itemCount = 5,
     this.spacing = 0.0,
diff --git a/lib/components/shimmer/gf_shimmer.dart b/lib/components/shimmer/gf_shimmer.dart
@@ -3,6 +3,7 @@ import 'package:flutter/rendering.dart';
 import 'package:getwidget/getwidget.dart';
 
 class GFShimmer extends StatefulWidget {
+  /// [GFShimmer] shows shimmer effect.
   const GFShimmer({
     Key key,
     @required this.child,
@@ -125,7 +126,9 @@ class _GFShimmerState extends State<GFShimmer>
 
   @override
   void dispose() {
-    _controller.dispose();
+    if (_controller != null) {
+      _controller.dispose();
+    }
     super.dispose();
   }
 }
diff --git a/lib/components/sticky_header/gf_sticky_header.dart b/lib/components/sticky_header/gf_sticky_header.dart
@@ -5,9 +5,8 @@ import 'package:flutter/widgets.dart';
 import 'package:meta/meta.dart';
 import 'package:getwidget/getwidget.dart';
 
-/// Place this widget inside a [ListView], [GridView], [CustomScrollView], [SingleChildScrollView] or similar.
-
 class GFStickyHeader extends MultiChildRenderObjectWidget {
+  /// Place this widget inside a [ListView], [GridView], [CustomScrollView], [SingleChildScrollView] or similar.
   GFStickyHeader(
       {Key key,
       @required this.stickyContent,
diff --git a/lib/components/sticky_header/gf_sticky_header_builder.dart b/lib/components/sticky_header/gf_sticky_header_builder.dart
@@ -2,11 +2,12 @@ import 'package:flutter/material.dart';
 import 'package:getwidget/getwidget.dart';
 
 typedef StickyHeaderWidgetBuilder = Widget Function(
-    BuildContext context, double stuckValue);
-
-/// Place this widget inside a [ListView], [GridView], [CustomScrollView], [SingleChildScrollView] or similar.
+  BuildContext context,
+  double stuckValue,
+);
 
 class GFStickyHeaderBuilder extends StatefulWidget {
+  /// Place this widget inside a [ListView], [GridView], [CustomScrollView], [SingleChildScrollView] or similar.
   /// Constructs a new [GFStickyHeaderBuilder] widget.
   const GFStickyHeaderBuilder({
     Key key,
diff --git a/lib/components/sticky_header/render_gf_sticky_header.dart b/lib/components/sticky_header/render_gf_sticky_header.dart
@@ -132,10 +132,8 @@ class RenderGFStickyHeader extends RenderBox
     assert(childCount == 2);
     _stickyContentBody.layout(constraints.loosen(), parentUsesSize: true);
     _contentBody.layout(constraints.loosen(), parentUsesSize: true);
-
     final stickyContentBodyHeight = _stickyContentBody.size.height;
     final contentBodyHeight = _contentBody.size.height;
-
     final height = max(
         constraints.minHeight,
         _enableHeaderOverlap
@@ -145,20 +143,15 @@ class RenderGFStickyHeader extends RenderBox
 
     size = Size(
         constraints.constrainWidth(width), constraints.constrainHeight(height));
-
     final double stickyContentBodyOffset = getHeaderTileStuckOffset();
-
     assert(constraints != null);
 
     double crossSize = 0;
     double allottedSize = 0;
     RenderBox child = firstChild;
-    // ignore: unused_local_variable
-    int totalChildren = 0;
     while (child != null) {
       // ignore: avoid_as
       final FlexParentData childParentData = child.parentData as FlexParentData;
-      totalChildren++;
       final int flex = _getFlex(child);
       if (flex > 0) {
       } else {
diff --git a/lib/components/tabs/gf_segment_tabs.dart b/lib/components/tabs/gf_segment_tabs.dart
@@ -11,8 +11,8 @@ class GFSegmentTabs extends StatefulWidget {
   /// [GFSegmentTabs] are best used as an alternative for [GFTabBar].
   const GFSegmentTabs(
       {Key key,
-//      this.initialIndex = 0,
       @required this.length,
+      // this.initialIndex = 0,
       this.height,
       this.width,
       this.border,
@@ -31,13 +31,13 @@ class GFSegmentTabs extends StatefulWidget {
       this.tabs,
       this.tabController})
       : assert(length != null && length >= 0),
-//        assert(initialIndex != null &&
-//            initialIndex >= 0 &&
-//            (length == 0 || initialIndex < length)),
+        // assert(initialIndex != null &&
+        //     initialIndex >= 0 &&
+        //     (length == 0 || initialIndex < length)),
         super(key: key);
 
-//  /// The initial index of the selected tab. Defaults to zero.
-//  final int initialIndex;
+  // /// The initial index of the selected tab. Defaults to zero.
+  // final int initialIndex;
 
   /// The total number of tabs. Typically greater than one. Must match [TabBar.tabs]'s and
   /// [TabBarView.children]'s length.
@@ -178,7 +178,7 @@ class _GFSegmentTabsState extends State<GFSegmentTabs> {
           borderRadius: widget.borderRadius ?? BorderRadius.circular(2),
         ),
         child: DefaultTabController(
-//          initialIndex: widget.initialIndex,
+          // initialIndex: widget.initialIndex,
           length: widget.length,
           child: Material(
             borderRadius: widget.borderRadius ?? BorderRadius.circular(2),
diff --git a/lib/components/tabs/gf_tabbar.dart b/lib/components/tabs/gf_tabbar.dart
@@ -9,15 +9,13 @@ import 'package:flutter/foundation.dart';
 ///
 /// Typically created as the [AppBar.bottom] part of an [AppBar] and in
 /// conjunction with a [TabBarView].
-
 class GFTabBar extends StatefulWidget {
   /// Creates a material design tab bar.
-  ///
   /// The [tabs] argument must not be null and its length must match the [controller]'s
   /// [TabController.length].
   const GFTabBar({
     Key key,
-//    this.initialIndex = 0,
+    // this.initialIndex = 0,
     @required this.length,
     this.isScrollable = false,
     this.tabBarHeight,
@@ -37,13 +35,13 @@ class GFTabBar extends StatefulWidget {
     this.shape,
   })  : assert(length != null && length >= 0),
         assert(isScrollable != null),
-//        assert(initialIndex != null &&
-//            initialIndex >= 0 &&
-//            (length == 0 || initialIndex < length)),
+        // assert(initialIndex != null &&
+        //     initialIndex >= 0 &&
+        //     (length == 0 || initialIndex < length)),
         super(key: key);
 
-//  /// The initial index of the selected tab. Defaults to zero.
-//  final int initialIndex;
+  // /// The initial index of the selected tab. Defaults to zero.
+  // final int initialIndex;
 
   /// The total number of tabs. Typically greater than one. Must match [TabBar.tabs]'s and
   /// [TabBarView.children]'s length.
diff --git a/lib/components/tabs/gf_tabbar_view.dart b/lib/components/tabs/gf_tabbar_view.dart
@@ -5,14 +5,10 @@ import 'package:flutter/widgets.dart';
 import 'package:flutter/gestures.dart' show DragStartBehavior;
 import 'package:getwidget/getwidget.dart';
 
-/// A page view that displays the widget which corresponds to the currently
-/// selected tab.
-///
+/// A page view that displays the widget which corresponds to the currently selected tab.
 /// This widget is typically used in conjunction with a [GFTabBar] or [GFSegmentTabs].
-///
 class GFTabBarView extends StatefulWidget {
   /// Creates a page view with one child per tab.
-  ///
   /// The length of [children] must be the same as the [controller]'s length.
   const GFTabBarView({
     Key key,
@@ -29,19 +25,15 @@ class GFTabBarView extends StatefulWidget {
   final TabController controller;
 
   /// One widget per tab.
-  ///
   /// Its length must match the length of the [GFTabBar.tabs]
   /// list, as well as the [controller]'s [TabController.length].
   final List<Widget> children;
 
   /// How the page view should respond to user input.
-  ///
   /// For example, determines how the page view continues to animate after the
   /// user stops dragging the page view.
-  ///
   /// The physics are modified to snap to page boundaries using
   /// [PageScrollPhysics] prior to being used.
-  ///
   /// Defaults to matching platform conventions.
   final ScrollPhysics physics;
 
@@ -84,7 +76,6 @@ class _GFTabBarViewState extends State<GFTabBarView> {
       }
       return true;
     }());
-
     if (newController == _controller) {
       return;
     }
@@ -141,7 +132,6 @@ class _GFTabBarViewState extends State<GFTabBarView> {
     if (_warpUnderwayCount > 0 || !_controller.indexIsChanging) {
       return;
     } // This widget is driving the controller's animation.
-
     if (_controller.index != _currentIndex) {
       _currentIndex = _controller.index;
       _warpToCurrentIndex();
diff --git a/lib/components/toast/gf_toast.dart b/lib/components/toast/gf_toast.dart
@@ -110,7 +110,6 @@ class _GFToastState extends State<GFToast> with TickerProviderStateMixin {
   void dispose() {
     animationController.dispose();
     fadeanimationController.dispose();
-
     super.dispose();
   }
 
@@ -171,5 +170,6 @@ class _GFToastState extends State<GFToast> with TickerProviderStateMixin {
                 ),
               ),
             ],
-          ));
+          ),
+        );
 }
diff --git a/lib/getwidget.dart b/lib/getwidget.dart
@@ -46,7 +46,7 @@ export 'package:getwidget/components/toast/gf_toast.dart';
 export 'package:getwidget/components/toggle/gf_toggle.dart';
 export 'package:getwidget/components/typography/gf_typography.dart';
 export 'package:getwidget/components/dropdown/gf_dropdown.dart';
-export 'package:getwidget/components/dropdown/multilevel.dart';
+export 'package:getwidget/components/dropdown/gf_multiselect.dart';
 
 export 'colors/gf_color.dart';
 export 'direction/gf_shimmer_direction.dart';
