Is smart expand/shrink selection supported?

[rynoV]

Referring to the shrink/expand selection feature in vscode, does ionide support this selection based on syntax? For example expanding selection to the expression at point, or current let binding

I was looking at this commit which makes me think it should be supported, but for me the selection works essentially like a text file, only expanding based on whitespace.

[baronfel]

It is supported, but it's based on the untyped walker that you see in that commit. If there are shrinks/expands that feel weird, it's possible that we're not walking the tree correctly for that syntax shape, or some other similar problem in our implementation.

[rynoV]

I tried the same with the FirstIonideProject from here, pretty much the same result:

[Error - 12:25:20] Request textDocument/documentSymbol failed.
  Message: No declarations for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:25:20] Request textDocument/documentSymbol failed.
  Message: No declarations for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:25:20] Request textDocument/inlayHint failed.
  Message: No typecheck results for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:25:20] Request textDocument/semanticTokens/range failed.
  Message: No typecheck results for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:25:20] Request textDocument/hover failed.
  Message: No typecheck results for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:25:20] Request textDocument/semanticTokens/full failed.
  Message: No typecheck results for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 

In the Program.fs file below, with cursor in the string, it selects by word then line (but I'm expecting it to select within and around the string)

// For more information see https://aka.ms/fsharp-console-apps
printfn "Hello from F#"

[rynoV]

This mostly seems like the language server hasn't correctly typechecked your code, and this specific feature is coded against typechecking, not just syntax trees, so you're getting that error. In the absence of data coming back from the LSP, VSCode is falling back to the 'tokenization' rules that we tell it about F#.

Hmm I wonder if the order of typechecking and other operations is off then, because both projects are typechecking otherwise and other language features are working

[baronfel]

the tooling still hasn't typechecked, so I wouldn't expect any difference. Can you try doing an explicit dotnet restore for the project and then reload VSCode?

[rynoV]

I closed vscode, ran dotnet restore in FirstIonideProject, after the first time reopening vscode it had the same behaviour and there wasn't any "F#" in the "Output" panel, I repeated the process and now there is "F#" with pretty much the same output and same behaviour:

[Error - 12:37:37] Request textDocument/documentSymbol failed.
  Message: No declarations for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:37:37] Request textDocument/documentSymbol failed.
  Message: No declarations for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:37:37] Request textDocument/inlayHint failed.
  Message: No typecheck results for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:37:37] Request textDocument/semanticTokens/range failed.
  Message: No typecheck results for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 
[Error - 12:37:37] Request textDocument/semanticTokens/full failed.
  Message: No typecheck results for /home/calum/code/FirstIonideProject/Program.fs
  Code: -32603 

[rynoV]

It also seems to be targeting net8.0 for FirstIonideProject, if that makes any difference. And for my original project it's targeting net6.0, and there is multiple fsproj files in subdirectories. On the original project dotnet restore also didn't change anything, and opening vscode only in one of the subdirectories didn't change anything either.