Skip to content

[Repo Assist] fix: remove unused FSharp.inlineValues settings that suppressed pipeline hints #2147

@github-actions

Description

@github-actions

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Closes #1963

The FSharp.inlineValues.enabled and FSharp.inlineValues.prefix settings were introduced as a migration path from FSharp.pipelineHints, but the actual VS Code InlineValuesProvider API was never implemented. No InlineValuesProvider is registered anywhere in the codebase — only one line of code ever read FSharp.inlineValues.enabled, and that line used it to suppress pipeline hints.

The result: users who had FSharp.inlineValues.enabled: true in their settings (perhaps expecting "inline values" to do something useful) would silently lose pipeline hints with no explanation.

Changes

  • release/package.json: Remove FSharp.inlineValues.enabled and FSharp.inlineValues.prefix settings
  • src/Components/LineLens/PipelineHints.fs: Remove the && not (cfg.get ("FSharp.inlineValues.enabled", false)) guard that suppressed pipeline hints

Root Cause

// Before (PipelineHints.fs)
enabled =
    cfg.get ("FSharp.pipelineHints.enabled", defaultConfig.enabled)
    && not (cfg.get ("FSharp.inlineValues.enabled", false))
    //       ^ this check silently disabled pipeline hints
    //         but no InlineValuesProvider was ever registered

Trade-offs

  • Users who previously used FSharp.inlineValues.enabled: true to disable pipeline hints will need to switch to FSharp.pipelineHints.enabled: false instead. This is a minor breaking change but the old setting was already misleading/undocumented in its actual effect.
  • No new functionality is added — this purely removes dead configuration and restores expected pipeline-hint behaviour.

Test Status

Build verified passing (dotnet fable src/Ionide.FSharp.fsproj) with no new errors (only pre-existing deprecation warnings unrelated to these changes).

Generated by Repo Assist ·

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f

Warning

🛡️ Protected Files

This was originally intended as a pull request, but the patch modifies protected files: package.json.

These files may affect project dependencies, CI/CD pipelines, or agent behaviour. Please review the changes carefully before creating the pull request.

Click here to create the pull request once you have reviewed the changes

To route changes like this to a review issue instead of blocking, configure protected-files: fallback-to-issue in your workflow configuration.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions