-
-
Notifications
You must be signed in to change notification settings - Fork 298
Description
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Closes #1963
The FSharp.inlineValues.enabled and FSharp.inlineValues.prefix settings were introduced as a migration path from FSharp.pipelineHints, but the actual VS Code InlineValuesProvider API was never implemented. No InlineValuesProvider is registered anywhere in the codebase — only one line of code ever read FSharp.inlineValues.enabled, and that line used it to suppress pipeline hints.
The result: users who had FSharp.inlineValues.enabled: true in their settings (perhaps expecting "inline values" to do something useful) would silently lose pipeline hints with no explanation.
Changes
release/package.json: RemoveFSharp.inlineValues.enabledandFSharp.inlineValues.prefixsettingssrc/Components/LineLens/PipelineHints.fs: Remove the&& not (cfg.get ("FSharp.inlineValues.enabled", false))guard that suppressed pipeline hints
Root Cause
// Before (PipelineHints.fs)
enabled =
cfg.get ("FSharp.pipelineHints.enabled", defaultConfig.enabled)
&& not (cfg.get ("FSharp.inlineValues.enabled", false))
// ^ this check silently disabled pipeline hints
// but no InlineValuesProvider was ever registeredTrade-offs
- Users who previously used
FSharp.inlineValues.enabled: trueto disable pipeline hints will need to switch toFSharp.pipelineHints.enabled: falseinstead. This is a minor breaking change but the old setting was already misleading/undocumented in its actual effect. - No new functionality is added — this purely removes dead configuration and restores expected pipeline-hint behaviour.
Test Status
Build verified passing (dotnet fable src/Ionide.FSharp.fsproj) with no new errors (only pre-existing deprecation warnings unrelated to these changes).
Generated by Repo Assist · ◷
To install this agentic workflow, run
gh aw add githubnext/agentics/workflows/repo-assist.md@346204513ecfa08b81566450d7d599556807389f
Warning
🛡️ Protected Files
This was originally intended as a pull request, but the patch modifies protected files: package.json.
These files may affect project dependencies, CI/CD pipelines, or agent behaviour. Please review the changes carefully before creating the pull request.
Click here to create the pull request once you have reviewed the changes
To route changes like this to a review issue instead of blocking, configure protected-files: fallback-to-issue in your workflow configuration.