✨ Ensure server is started (#86)

**What is the purpose of this pull request/Why do we need it?**
If a server is provisioned but somehow not started, you'd have to start
the server manually. This now happens automatically, so the controller
checks if the server is powered on, and if not, is starts the server.

**Description of changes:**
Automatically start servers if they are powered off. 

**Checklist:**
- [x] Documentation updated
- [x] Unit Tests added
- [x] Includes
[emojis](https://github.com/kubernetes-sigs/kubebuilder-release-tools?tab=readme-ov-file#kubebuilder-project-versioning)

Author: jriedel-ionos

internal/ionoscloud/client.go

@@ -34,6 +34,9 @@ type Client interface {
 	GetServer(ctx context.Context, datacenterID, serverID string) (*sdk.Server, error)
 	// DeleteServer deletes the server that matches the provided serverID in the specified data center.
 	DeleteServer(ctx context.Context, datacenterID, serverID string) (string, error)
+	// StartServer starts the server that matches the provided serverID in the specified data center.
+	// Returning the location and an error if starting the server fails.
+	StartServer(ctx context.Context, datacenterID, serverID string) (string, error)
 	// CreateLAN creates a new LAN with the provided properties in the specified data center, returning the request path.
 	CreateLAN(ctx context.Context, datacenterID string, properties sdk.LanPropertiesPost) (string, error)
 	// PatchLAN patches the LAN that matches lanID in the specified data center with the provided properties, returning the request location.

internal/ionoscloud/client/client.go

@@ -155,6 +155,28 @@ func (c *IonosCloudClient) DeleteServer(ctx context.Context, datacenterID, serve
 	return "", errLocationHeaderEmpty
 }
 
+// StartServer starts the server that matches the provided serverID in the specified data center.
+// Returning the location and an error if starting the server fails.
+func (c *IonosCloudClient) StartServer(ctx context.Context, datacenterID, serverID string) (string, error) {
+	if datacenterID == "" {
+		return "", errDatacenterIDIsEmpty
+	}
+	if serverID == "" {
+		return "", errServerIDIsEmpty
+	}
+	req, err := c.API.ServersApi.
+		DatacentersServersStartPost(ctx, datacenterID, serverID).
+		Execute()
+	if err != nil {
+		return "", fmt.Errorf(apiCallErrWrapper, err)
+	}
+	if location := req.Header.Get(locationHeaderKey); location != "" {
+		return location, nil
+	}
+
+	return "", errLocationHeaderEmpty
+}
+
 // CreateLAN creates a new LAN with the provided properties in the specified data center, returning the request location.
 func (c *IonosCloudClient) CreateLAN(ctx context.Context, datacenterID string, properties sdk.LanPropertiesPost,
 ) (string, error) {

internal/ionoscloud/clienttest/mock_client.go

@@ -65,7 +65,7 @@ func (s *Service) ReconcileServer(ctx context.Context, ms *scope.Machine) (reque
 	if server != nil {
 		// Server is available
 
-		if !s.isServerAvailable(server) {
+		if !s.isServerAvailable(ms, server) {
 			// server is still provisioning, checking again later
 			return true, nil
 		}
@@ -138,18 +138,20 @@ func (s *Service) FinalizeMachineProvisioning(_ context.Context, ms *scope.Machi
 	return false, nil
 }
 
-func (s *Service) isServerAvailable(server *sdk.Server) bool {
+func (s *Service) isServerAvailable(ms *scope.Machine, server *sdk.Server) bool {
 	log := s.logger.WithName("isServerAvailable")
 	if state := getState(server); !isAvailable(state) {
 		log.Info("Server is not available yet", "state", state)
 		return false
 	}
 
-	// TODO ensure server is started
 	if vmState := getVMState(server); !isRunning(vmState) {
-		log.Info("Server is not running yet", "state", vmState)
-		// TODO start server
-		return false
+		err := s.startServer(context.Background(), ms.DatacenterID(), *server.Id)
+		if err != nil {
+			log.Error(err, "Failed to start the server")
+			return false
+		}
+		return true
 	}
 
 	return true
@@ -225,6 +227,20 @@ func (s *Service) deleteServer(ctx context.Context, ms *scope.Machine, serverID
 	return nil
 }
 
+func (s *Service) startServer(ctx context.Context, datacenterID, serverID string) error {
+	log := s.logger.WithName("startServer")
+
+	log.V(4).Info("Starting server", "serverID", serverID)
+	requestLocation, err := s.ionosClient.StartServer(ctx, datacenterID, serverID)
+	if err != nil {
+		return fmt.Errorf("failed to request server start: %w", err)
+	}
+
+	log.Info("Successfully requested for server start", "location", requestLocation)
+	log.V(4).Info("Done starting server")
+	return nil
+}
+
 func (s *Service) getLatestServerCreationRequest(ctx context.Context, ms *scope.Machine) (*requestInfo, error) {
 	return getMatchingRequest(
 		ctx,

internal/service/cloud/server.go

@@ -104,6 +104,29 @@ func (s *serverSuite) TestReconcileServerRequestDoneStateAvailable() {
 	s.False(requeue)
 }
 
+func (s *serverSuite) TestReconcileServerRequestDoneStateAvailableTurnedOff() {
+	s.prepareReconcileServerRequestTest()
+	s.mockGetServerCreationRequest().Return([]sdk.Request{s.examplePostRequest(sdk.RequestStatusDone)}, nil)
+	s.mockListServers().Return(&sdk.Servers{Items: &[]sdk.Server{
+		{
+			Id: ptr.To(exampleServerID),
+			Metadata: &sdk.DatacenterElementMetadata{
+				State: ptr.To(sdk.Available),
+			},
+			Properties: &sdk.ServerProperties{
+				Name:    ptr.To(s.service.serverName(s.infraMachine)),
+				VmState: ptr.To(sdk.Available),
+			},
+		},
+	}}, nil).Once()
+
+	s.mockStartServer().Return("", nil)
+
+	requeue, err := s.service.ReconcileServer(s.ctx, s.machineScope)
+	s.NoError(err)
+	s.False(requeue)
+}
+
 func (s *serverSuite) TestReconcileServerNoRequest() {
 	s.prepareReconcileServerRequestTest()
 	s.mockGetServerCreationRequest().Return([]sdk.Request{}, nil)
@@ -330,6 +353,10 @@ func (s *serverSuite) mockCreateServer() *clienttest.MockClient_CreateServer_Cal
 	)
 }
 
+func (s *serverSuite) mockStartServer() *clienttest.MockClient_StartServer_Call {
+	return s.ionosClient.EXPECT().StartServer(s.ctx, s.machineScope.DatacenterID(), exampleServerID)
+}
+
 func (s *serverSuite) mockListLANs() *clienttest.MockClient_ListLANs_Call {
 	return s.ionosClient.EXPECT().ListLANs(s.ctx, s.machineScope.DatacenterID())
 }