CAPI 1.9.5, k8s/* 0.31.6, controller-runtime 0.19.6, controller-gen 0.16.5 (#388)

* config/{crd,rbac}: regen
* bump github.com/google/cel-go to 0.20.1
* docs, e2e: bump kubernetes to 1.31.6
* */*.go: silence lint about cluster-api/errors and Failure{Message,Reason} deprecation

Author: wikkyk

Makefile

@@ -180,7 +180,7 @@ ENVTEST ?= $(LOCALBIN)/setup-envtest
 
 ## Tool Versions
 KUSTOMIZE_VERSION ?= v5.0.0
-CONTROLLER_TOOLS_VERSION ?= v0.15.0
+CONTROLLER_TOOLS_VERSION ?= v0.16.5
 ENVTEST_VERSION ?= latest
 
 KUSTOMIZE_INSTALL_SCRIPT ?= "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh"

api/v1alpha1/proxmoxcluster_types.go

@@ -21,7 +21,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/utils/ptr"
 	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
-	"sigs.k8s.io/cluster-api/errors"
+	"sigs.k8s.io/cluster-api/errors" //nolint:staticcheck
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 

api/v1alpha1/proxmoxmachine_types.go

@@ -23,7 +23,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
-	clusterapierrors "sigs.k8s.io/cluster-api/errors"
+	clusterapierrors "sigs.k8s.io/cluster-api/errors" //nolint:staticcheck
 )
 
 const (

config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclusters.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.15.0
+    controller-gen.kubebuilder.io/version: v0.16.5
   name: proxmoxclusters.infrastructure.cluster.x-k8s.io
 spec:
   group: infrastructure.cluster.x-k8s.io
@@ -78,7 +78,6 @@ spec:
                             for operations. This implies that VMs can be cloned on different nodes from
                             the node which holds the VM template.
 
-
                             This field is optional and should only be set if you want to restrict
                             the nodes where the VM can be cloned.
                             If not set, the ProxmoxCluster will be used to determine the nodes.
@@ -121,7 +120,6 @@ spec:
                                   description: |-
                                     Size defines the size in gigabyte.
 
-
                                     As Proxmox does not support shrinking, the size
                                     must be bigger than the already configured size in the
                                     template.
@@ -545,17 +543,14 @@ spec:
                             This node will be used to locate the template VM, which will
                             be used for cloning operations.
 
-
                             Cloning will be performed according to the configuration.
                             Setting the `Target` field will tell Proxmox to clone the
                             VM on that target node.
 
-
                             When Target is not set and the ProxmoxCluster contains
                             a set of `AllowedNodes`, the algorithm will instead evenly
                             distribute the VMs across the nodes from that list.
 
-
                             If neither a `Target` nor `AllowedNodes` was set, the VM
                             will be cloned onto the same node as SourceNode.
                           minLength: 1
@@ -800,20 +795,20 @@ spec:
                       description: |-
                         The reason for the condition's last transition in CamelCase.
                         The specific API may choose whether or not this field is considered a guaranteed API.
-                        This field may not be empty.
+                        This field may be empty.
                       type: string
                     severity:
                       description: |-
-                        Severity provides an explicit classification of Reason code, so the users or machines can immediately
+                        severity provides an explicit classification of Reason code, so the users or machines can immediately
                         understand the current situation and act accordingly.
                         The Severity field MUST be set only when Status=False.
                       type: string
                     status:
-                      description: Status of the condition, one of True, False, Unknown.
+                      description: status of the condition, one of True, False, Unknown.
                       type: string
                     type:
                       description: |-
-                        Type of condition in CamelCase or in foo.example.com/CamelCase.
+                        type of condition in CamelCase or in foo.example.com/CamelCase.
                         Many .condition.type values are consistent across resources like Available, but because arbitrary conditions
                         can be useful (see .node.status.conditions), the ability to deconflict is important.
                       type: string
@@ -829,7 +824,6 @@ spec:
                   reconciling the Machine and will contain a more verbose string suitable
                   for logging and human consumption.
 
-
                   This field should not be set for transitive errors that a controller
                   faces that are expected to be fixed automatically over
                   time (like service outages), but instead indicate that something is
@@ -839,7 +833,6 @@ spec:
                   spec, values that are unsupported by the controller, or the
                   responsible controller itself being critically misconfigured.
 
-
                   Any transient errors that occur during the reconciliation of ProxmoxMachines
                   can be added as events to the ProxmoxCluster object and/or logged in the
                   controller's output.
@@ -850,7 +843,6 @@ spec:
                   reconciling the Machine and will contain a succinct value suitable
                   for machine interpretation.
 
-
                   This field should not be set for transitive errors that a controller
                   faces that are expected to be fixed automatically over
                   time (like service outages), but instead indicate that something is
@@ -860,7 +852,6 @@ spec:
                   spec, values that are unsupported by the controller, or the
                   responsible controller itself being critically misconfigured.
 
-
                   Any transient errors that occur during the reconciliation of ProxmoxCluster
                   can be added as events to the ProxmoxCluster object and/or logged in the
                   controller's output.
@@ -880,9 +871,7 @@ spec:
                         This field is effectively required, but due to backwards compatibility is
                         allowed to be empty. Instances of this type with an empty value here are
                         almost certainly wrong.
-                        TODO: Add other useful fields. apiVersion, kind, uid?
                         More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
-                        TODO: Drop `kubebuilder:default` when controller-gen doesn't need it https://github.com/kubernetes-sigs/kubebuilder/issues/3896.
                       type: string
                   type: object
                   x-kubernetes-map-type: atomic
@@ -910,9 +899,7 @@ spec:
                                 This field is effectively required, but due to backwards compatibility is
                                 allowed to be empty. Instances of this type with an empty value here are
                                 almost certainly wrong.
-                                TODO: Add other useful fields. apiVersion, kind, uid?
                                 More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
-                                TODO: Drop `kubebuilder:default` when controller-gen doesn't need it https://github.com/kubernetes-sigs/kubebuilder/issues/3896.
                               type: string
                           type: object
                           x-kubernetes-map-type: atomic
@@ -941,9 +928,7 @@ spec:
                                 This field is effectively required, but due to backwards compatibility is
                                 allowed to be empty. Instances of this type with an empty value here are
                                 almost certainly wrong.
-                                TODO: Add other useful fields. apiVersion, kind, uid?
                                 More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
-                                TODO: Drop `kubebuilder:default` when controller-gen doesn't need it https://github.com/kubernetes-sigs/kubebuilder/issues/3896.
                               type: string
                           type: object
                           x-kubernetes-map-type: atomic

config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxclustertemplates.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.15.0
+    controller-gen.kubebuilder.io/version: v0.16.5
   name: proxmoxclustertemplates.infrastructure.cluster.x-k8s.io
 spec:
   group: infrastructure.cluster.x-k8s.io
@@ -57,7 +57,7 @@ spec:
                         additionalProperties:
                           type: string
                         description: |-
-                          Annotations is an unstructured key value map stored with a resource that may be
+                          annotations is an unstructured key value map stored with a resource that may be
                           set by external tools to store and retrieve arbitrary metadata. They are not
                           queryable and should be preserved when modifying objects.
                           More info: http://kubernetes.io/docs/user-guide/annotations
@@ -100,7 +100,6 @@ spec:
                                     for operations. This implies that VMs can be cloned on different nodes from
                                     the node which holds the VM template.
 
-
                                     This field is optional and should only be set if you want to restrict
                                     the nodes where the VM can be cloned.
                                     If not set, the ProxmoxCluster will be used to determine the nodes.
@@ -145,7 +144,6 @@ spec:
                                           description: |-
                                             Size defines the size in gigabyte.
 
-
                                             As Proxmox does not support shrinking, the size
                                             must be bigger than the already configured size in the
                                             template.
@@ -586,17 +584,14 @@ spec:
                                     This node will be used to locate the template VM, which will
                                     be used for cloning operations.
 
-
                                     Cloning will be performed according to the configuration.
                                     Setting the `Target` field will tell Proxmox to clone the
                                     VM on that target node.
 
-
                                     When Target is not set and the ProxmoxCluster contains
                                     a set of `AllowedNodes`, the algorithm will instead evenly
                                     distribute the VMs across the nodes from that list.
 
-
                                     If neither a `Target` nor `AllowedNodes` was set, the VM
                                     will be cloned onto the same node as SourceNode.
                                   minLength: 1

config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxmachines.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.15.0
+    controller-gen.kubebuilder.io/version: v0.16.5
   name: proxmoxmachines.infrastructure.cluster.x-k8s.io
 spec:
   group: infrastructure.cluster.x-k8s.io
@@ -71,7 +71,6 @@ spec:
                   for operations. This implies that VMs can be cloned on different nodes from
                   the node which holds the VM template.
 
-
                   This field is optional and should only be set if you want to restrict
                   the nodes where the VM can be cloned.
                   If not set, the ProxmoxCluster will be used to determine the nodes.
@@ -113,7 +112,6 @@ spec:
                         description: |-
                           Size defines the size in gigabyte.
 
-
                           As Proxmox does not support shrinking, the size
                           must be bigger than the already configured size in the
                           template.
@@ -513,17 +511,14 @@ spec:
                   This node will be used to locate the template VM, which will
                   be used for cloning operations.
 
-
                   Cloning will be performed according to the configuration.
                   Setting the `Target` field will tell Proxmox to clone the
                   VM on that target node.
 
-
                   When Target is not set and the ProxmoxCluster contains
                   a set of `AllowedNodes`, the algorithm will instead evenly
                   distribute the VMs across the nodes from that list.
 
-
                   If neither a `Target` nor `AllowedNodes` was set, the VM
                   will be cloned onto the same node as SourceNode.
                 minLength: 1
@@ -646,20 +641,20 @@ spec:
                       description: |-
                         The reason for the condition's last transition in CamelCase.
                         The specific API may choose whether or not this field is considered a guaranteed API.
-                        This field may not be empty.
+                        This field may be empty.
                       type: string
                     severity:
                       description: |-
-                        Severity provides an explicit classification of Reason code, so the users or machines can immediately
+                        severity provides an explicit classification of Reason code, so the users or machines can immediately
                         understand the current situation and act accordingly.
                         The Severity field MUST be set only when Status=False.
                       type: string
                     status:
-                      description: Status of the condition, one of True, False, Unknown.
+                      description: status of the condition, one of True, False, Unknown.
                       type: string
                     type:
                       description: |-
-                        Type of condition in CamelCase or in foo.example.com/CamelCase.
+                        type of condition in CamelCase or in foo.example.com/CamelCase.
                         Many .condition.type values are consistent across resources like Available, but because arbitrary conditions
                         can be useful (see .node.status.conditions), the ability to deconflict is important.
                       type: string
@@ -675,7 +670,6 @@ spec:
                   reconciling the Machine and will contain a more verbose string suitable
                   for logging and human consumption.
 
-
                   This field should not be set for transitive errors that a controller
                   faces that are expected to be fixed automatically over
                   time (like service outages), but instead indicate that something is
@@ -685,7 +679,6 @@ spec:
                   spec, values that are unsupported by the controller, or the
                   responsible controller itself being critically misconfigured.
 
-
                   Any transient errors that occur during the reconciliation of ProxmoxMachines
                   can be added as events to the ProxmoxMachine object and/or logged in the
                   controller's output.
@@ -696,7 +689,6 @@ spec:
                   reconciling the Machine and will contain a succinct value suitable
                   for machine interpretation.
 
-
                   This field should not be set for transitive errors that a controller
                   faces that are expected to be fixed automatically over
                   time (like service outages), but instead indicate that something is
@@ -706,7 +698,6 @@ spec:
                   spec, values that are unsupported by the controller, or the
                   responsible controller itself being critically misconfigured.
 
-
                   Any transient errors that occur during the reconciliation of ProxmoxMachines
                   can be added as events to the ProxmoxMachine object and/or logged in the
                   controller's output.

config/crd/bases/infrastructure.cluster.x-k8s.io_proxmoxmachinetemplates.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.15.0
+    controller-gen.kubebuilder.io/version: v0.16.5
   name: proxmoxmachinetemplates.infrastructure.cluster.x-k8s.io
 spec:
   group: infrastructure.cluster.x-k8s.io
@@ -57,7 +57,7 @@ spec:
                         additionalProperties:
                           type: string
                         description: |-
-                          Annotations is an unstructured key value map stored with a resource that may be
+                          annotations is an unstructured key value map stored with a resource that may be
                           set by external tools to store and retrieve arbitrary metadata. They are not
                           queryable and should be preserved when modifying objects.
                           More info: http://kubernetes.io/docs/user-guide/annotations
@@ -82,7 +82,6 @@ spec:
                           for operations. This implies that VMs can be cloned on different nodes from
                           the node which holds the VM template.
 
-
                           This field is optional and should only be set if you want to restrict
                           the nodes where the VM can be cloned.
                           If not set, the ProxmoxCluster will be used to determine the nodes.
@@ -125,7 +124,6 @@ spec:
                                 description: |-
                                   Size defines the size in gigabyte.
 
-
                                   As Proxmox does not support shrinking, the size
                                   must be bigger than the already configured size in the
                                   template.
@@ -545,17 +543,14 @@ spec:
                           This node will be used to locate the template VM, which will
                           be used for cloning operations.
 
-
                           Cloning will be performed according to the configuration.
                           Setting the `Target` field will tell Proxmox to clone the
                           VM on that target node.
 
-
                           When Target is not set and the ProxmoxCluster contains
                           a set of `AllowedNodes`, the algorithm will instead evenly
                           distribute the VMs across the nodes from that list.
 
-
                           If neither a `Target` nor `AllowedNodes` was set, the VM
                           will be cloned onto the same node as SourceNode.
                         minLength: 1