feat!: move logging logic to launch method (#57)

* feat!: remove SimCtlExtensions.log & tail dependency
* feat!: restructured launch method

1. Removed 'waitForDebugger' launch param. (Moved to 'options')
2. Added param 'options' for the launch options.
   Valid Options:
     - waitForDebugger (boolean)
     - stderr (string) - path to the log file
     - stdout (string) - path to the log file
     - arch (string)

Author: erisu

lib/simctl-extensions.js

@@ -23,9 +23,7 @@ THE SOFTWARE.
 */
 
 const path = require('path')
-const fs = require('fs')
 const { spawnSync } = require('child_process')
-const { Tail } = require('tail')
 
 const extensions = {
   start: function (deviceid) {
@@ -78,31 +76,6 @@ const extensions = {
       // Xcode 8 or older
       return spawnSync('xcrun', ['instruments', '-w', deviceid])
     }
-  },
-
-  log: function (deviceid, filepath) {
-    const tail = new Tail(
-      path.join(process.env.HOME, 'Library', 'Logs', 'CoreSimulator', deviceid, 'system.log')
-    )
-
-    tail.on('line', function (data) {
-      if (filepath) {
-        fs.appendFile(filepath, data + '\n', function (error) {
-          if (error) {
-            console.error('ERROR: ', error)
-            throw error
-          }
-        })
-      } else {
-        console.log(data)
-      }
-    })
-
-    tail.on('error', function (error) {
-      console.error('ERROR: ', error)
-    })
-
-    return tail
   }
 }
 

package-lock.json

@@ -7,9 +7,6 @@
     "url": "https://github.com/ios-control/simctl.git"
   },
   "main": "simctl.js",
-  "dependencies": {
-    "tail": "^2.2.6"
-  },
   "scripts": {
     "test": "node --test --experimental-test-coverage",
     "posttest": "npm run eslint",

package.json

@@ -102,17 +102,27 @@ module.exports = {
     return spawnSync('xcrun', ['simctl', 'uninstall', device, appIdentifier])
   },
 
-  launch: function (waitForDebugger, device, appIdentifier, argv) {
+  launch: function (device, appIdentifier, argv = [], options = {}) {
     const args = ['simctl', 'launch']
 
-    if (waitForDebugger) {
+    if (options.waitForDebugger) {
       args.push('--wait-for-debugger')
     }
+    if (options.stderr) {
+      args.push(`--stderr=${options.stderr}`)
+    }
+    if (options.stdout) {
+      args.push(`--stderr=${options.stdout}`)
+    }
+    if (options.arch) {
+      args.push(`--arch=${options.arch}`)
+    }
 
     args.push(device)
     args.push(appIdentifier)
+    args.push(...argv)
 
-    return spawnSync('xcrun', args.concat(argv))
+    return spawnSync('xcrun', args)
   },
 
   spawn: function (waitForDebugger, arch, device, pathToExecutable, argv) {

simctl.js

@@ -33,7 +33,6 @@ test('exports', (t) => {
   t.assert ||= require('node:assert')
 
   t.assert.equal(typeof SimCtlExtensions.start, 'function')
-  t.assert.equal(typeof SimCtlExtensions.log, 'function')
 })
 
 test('start', async (ctx) => {