Revise "confirmation rate" language in the network indicator

[saurabhtukul]

Description

Used firefly beta wallet.
Its shows 101 % confirmation rate which in any case could not be true.

The calculation for confirmation rate is faulty, it cannot be more than 100% whatever may be the criteria, which i assume is part of wallet.rs and firefly just shows the data.

Impact

Proof of Concept

download firefly beta wallet and create a new wallet and click on network status

Open feedback (optional)

Use this section to add any feedback related to the submission:

[saurabhtukul]

It will basically lead to faulty expectation from network when the load is too high...

[Thoralf-M]

The confirmation rate is calculated in the explorer and is "wrong" because the current mps can change and there can be messages parallel to a milestone in the tangle. At one time a milestone might confirm not all other messages that are there at this moment, because they are sent parallel to the milestone in the tangle and the next time it could reference also the messages that were parallel the previous time, then the milestone confirms more messages than were sent during the time from the last milestone and thus the confirmation rate is over 100%

[saurabhtukul]

If at current point ,it could shows wrong value, better not to show it...Its very ambiguous to user seeing more than 100% confirmation whatever the underlaying parallel universe, it should and must not cross 100% otherwise it basically depicts a flux state where consensus is not uniform.

[Thoralf-M]

It's not wrong, in this timeframe more messages got confirmed than sent

[saurabhtukul]

Then the definition of confirmation is wrong.You are confusing user...
Confirmation should only mean if all the transaction which is supposed to get confirmed in 10 sec(if thats the benchmark now) is confirmed or not.It will show 100% only if all those transaction which are meant to be confirmed within 10 secs are success-full.
Otherwise it has to be less than 100%..

[maxwellmattryan]

@saurabhtukul So would you propose just hard-limiting the rate (in Firefly) at 100% as to not confuse the user? Another alternative I can think of is a tooltip explaining this, however I'm leaning towards hard-limiting at 100% personally.

[rafaeldjpbrochado]

I agree this is an issue. Here's another discussion about it: #1532