Skip to content

Commit b12cbc9

Browse files
ziogaschrjorgemmsilva
authored andcommitted
cmd/geth, cmd/utils: rename config and flag to VMTraceJsonConfig (ethereum#29573)
renames the yaml config field VMTraceConfig to VMTraceJsonConfig, in order to be consistent with the renaming of the CLI flag.
1 parent d10ccaf commit b12cbc9

File tree

6 files changed

+17
-17
lines changed

6 files changed

+17
-17
lines changed

cmd/geth/chaincmd.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ if one is set. Otherwise it prints the genesis from the datadir.`,
100100
utils.MetricsInfluxDBOrganizationFlag,
101101
utils.TxLookupLimitFlag,
102102
utils.VMTraceFlag,
103-
utils.VMTraceConfigFlag,
103+
utils.VMTraceJsonConfigFlag,
104104
utils.TransactionHistoryFlag,
105105
utils.StateHistoryFlag,
106106
}, utils.DatabaseFlags),

cmd/geth/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ var (
137137
utils.DeveloperPeriodFlag,
138138
utils.VMEnableDebugFlag,
139139
utils.VMTraceFlag,
140-
utils.VMTraceConfigFlag,
140+
utils.VMTraceJsonConfigFlag,
141141
utils.NetworkIdFlag,
142142
utils.EthStatsURLFlag,
143143
utils.NoCompactionFlag,

cmd/utils/flags.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -544,7 +544,7 @@ var (
544544
Usage: "Name of tracer which should record internal VM operations (costly)",
545545
Category: flags.VMCategory,
546546
}
547-
VMTraceConfigFlag = &cli.StringFlag{
547+
VMTraceJsonConfigFlag = &cli.StringFlag{
548548
Name: "vmtrace.jsonconfig",
549549
Usage: "Tracer configuration (JSON)",
550550
Category: flags.VMCategory,
@@ -1903,12 +1903,12 @@ func SetEthConfig(ctx *cli.Context, stack *node.Node, cfg *ethconfig.Config) {
19031903
if ctx.IsSet(VMTraceFlag.Name) {
19041904
if name := ctx.String(VMTraceFlag.Name); name != "" {
19051905
var config string
1906-
if ctx.IsSet(VMTraceConfigFlag.Name) {
1907-
config = ctx.String(VMTraceConfigFlag.Name)
1906+
if ctx.IsSet(VMTraceJsonConfigFlag.Name) {
1907+
config = ctx.String(VMTraceJsonConfigFlag.Name)
19081908
}
19091909

19101910
cfg.VMTrace = name
1911-
cfg.VMTraceConfig = config
1911+
cfg.VMTraceJsonConfig = config
19121912
}
19131913
}
19141914
}
@@ -2192,8 +2192,8 @@ func MakeChain(ctx *cli.Context, stack *node.Node, readonly bool) (*core.BlockCh
21922192
if ctx.IsSet(VMTraceFlag.Name) {
21932193
if name := ctx.String(VMTraceFlag.Name); name != "" {
21942194
var config json.RawMessage
2195-
if ctx.IsSet(VMTraceConfigFlag.Name) {
2196-
config = json.RawMessage(ctx.String(VMTraceConfigFlag.Name))
2195+
if ctx.IsSet(VMTraceJsonConfigFlag.Name) {
2196+
config = json.RawMessage(ctx.String(VMTraceJsonConfigFlag.Name))
21972197
}
21982198
t, err := tracers.LiveDirectory.New(name, config)
21992199
if err != nil {

eth/backend.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ func New(stack *node.Node, config *ethconfig.Config) (*Ethereum, error) {
203203
)
204204
if config.VMTrace != "" {
205205
var traceConfig json.RawMessage
206-
if config.VMTraceConfig != "" {
207-
traceConfig = json.RawMessage(config.VMTraceConfig)
206+
if config.VMTraceJsonConfig != "" {
207+
traceConfig = json.RawMessage(config.VMTraceJsonConfig)
208208
}
209209
t, err := tracers.LiveDirectory.New(config.VMTrace, traceConfig)
210210
if err != nil {

eth/ethconfig/config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,8 @@ type Config struct {
142142
EnablePreimageRecording bool
143143

144144
// Enables VM tracing
145-
VMTrace string
146-
VMTraceConfig string
145+
VMTrace string
146+
VMTraceJsonConfig string
147147

148148
// Miscellaneous options
149149
DocRoot string `toml:"-"`

eth/ethconfig/gen_config.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)