feat(dapp): add expirationTime to Purchase, Renew, and RenewSubname amplitude events (#1029)

* feat(dapp): add expirationTime to Purchase, Renew, and RenewSubname dialogs

* chore: remove expiration property for renew

---------

Co-authored-by: msarcev <mario.sarcevic@iota.org>
Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio>

Author: 3 people

dapp/src/components/dialogs/PurchaseNameDialog.tsx

@@ -161,10 +161,14 @@ export function PurchaseNameDialog({ name, open, setOpen, onCompleted }: Purchas
                 queryKey: queryKey.publicName(account?.address || ''),
             });
 
+            const expirationDate = new Date();
+            expirationDate.setFullYear(expirationDate.getFullYear() + purchaseYears);
+            const expirationTime = expirationDate.getTime();
+
             ampli.purchasedName({
                 name,
                 amount: parseNanosToIota(price ?? 0),
-                expiration: purchaseYears, // tbd replace expiration with more meaningful name purchaseYears
+                expirationTime,
                 purchaseYears: purchaseYears,
                 discountName: couponCodes.join(','),
                 discountPercentage: applyDiscount ? (price - (discountedPrice ?? 0)) / price : 0,

dapp/src/components/dialogs/RenewNameDialog.tsx

@@ -142,9 +142,15 @@ export function RenewNameDialog({ setOpen, name, onRenew }: RenewDialogProps) {
             queryClient.invalidateQueries({
                 queryKey: queryKey.getObject(name),
             });
+            const currentExpiration = nameRecord?.nameRecord?.expirationDate
+                ? new Date(nameRecord.nameRecord.expirationDate)
+                : new Date();
+            currentExpiration.setFullYear(currentExpiration.getFullYear() + (renewYears || 0));
+            const expirationTime = currentExpiration.getTime();
+
             ampli.renewedName({
                 name,
-                expiration: renewYears || 0, // tbd replace with more meaningful name renewYears
+                expirationTime,
                 renewYears: renewYears || 0,
             });
             toast.success('Name renewed successfully');

dapp/src/components/dialogs/RenewSubameDialog.tsx

@@ -132,11 +132,13 @@ export function RenewSubnameDialog({ setOpen, name, onRenew }: RenewDialogProps)
             queryClient.invalidateQueries({
                 queryKey: queryKey.getObject(name),
             });
+            const expirationTime = expirationDate ? expirationDate.getTime() : Date.now();
+
             ampli.renewedSubname({
                 name,
                 // TODO expirationType `custom` will be added after implement https://github.com/iotaledger/iota-names/issues/915
                 expirationType: 'parent',
-                expirationTime: expirationDate?.getTime().toString() || '',
+                expirationTime,
             });
             toast.success('Subname renewed successfully');
         },

dapp/src/lib/utils/analytics/ampli/index.ts

@@ -162,7 +162,7 @@ export interface PurchasedNameProperties {
      * |---|---|
      * | Type | number |
      */
-    expiration: number;
+    expirationTime: number;
     name: string;
     /**
      * Property created as alternative of `expiration` with more readable name.
@@ -180,7 +180,7 @@ export interface RenewedNameProperties {
      * |---|---|
      * | Type | number |
      */
-    expiration: number;
+    expirationTime: number;
     name: string;
     /**
      * | Rule | Value |
@@ -191,7 +191,12 @@ export interface RenewedNameProperties {
 }
 
 export interface RenewedSubnameProperties {
-    expirationTime: string;
+    /**
+     * | Rule | Value |
+     * |---|---|
+     * | Type | number |
+     */
+    expirationTime: number;
     expirationType: string;
     name: string;
 }
@@ -583,7 +588,7 @@ export class Ampli {
    *
    * Event has no description in tracking plan.
    *
-   * @param properties The event's properties (e.g. expiration)
+   * @param properties The event's properties (e.g. expirationTime)
    * @param options Amplitude event options.
    */
   renewedName(