Skip to content

Commit bee13b8

Browse files
KeitoTadashibegonaalvarezdpanteleymonchuk
authored
feat(dapp): add non-current address confirmation (#1037)
* feat(dapp): add non-current address confirmation * chore: update test --------- Co-authored-by: Begoña Álvarez de la Cruz <balvarez@boxfish.studio> Co-authored-by: Panteley <panteleymonchuk@gmail.com>
1 parent abbf402 commit bee13b8

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

dapp/src/components/dialogs/ConnectToAddressDialog.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,6 @@ export function ConnectToAddressDialog({ name, setOpen }: ConnectToAddressDialog
160160
if (editTargetAddress.length === 0) {
161161
toast.success(`Successfully disconnected ${cleanName}`);
162162
setOpen(false);
163-
} else if (!isTargetingCurrentAddress) {
164-
toast.success(
165-
`Successfully connected ${cleanName} to address ${formatAddress(editTargetAddress)}`,
166-
);
167-
setOpen(false);
168163
}
169164
},
170165
onError: (error) => {
@@ -376,15 +371,15 @@ function UpdatesResult({ name, updates }: { name: string; updates: NameUpdate[]
376371
});
377372

378373
const isNamePublic = updates.some((update) => update.type === 'set-public');
379-
374+
const targetAddress = updates.find((update) => update.type === 'set-target-address')?.address;
380375
return (
381376
<div className="flex flex-col gap-y-md">
382377
<div className="flex flex-col gap-y-sm">
383378
<div className="text-headline-sm text-iota-neutral-100">{cleanName}</div>
384379
<div>
385380
<Chip
386381
leadingElement={<Link className="w-4 h-4" />}
387-
label={formatAddress(account?.address || '')}
382+
label={formatAddress(targetAddress || '')}
388383
trailingElement={<Copy className="w-4 h-4" />}
389384
onClick={copyAddressToClipboard}
390385
type={isNamePublic ? ChipType.Success : ChipType.Elevated}

dapp/tests/management/management.spec.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,10 +220,8 @@ test.describe.serial('Name Management Tests', () => {
220220
await dialog.getByRole('button', { name: 'Apply' }).click();
221221
(await context.waitForEvent('page')).getByRole('button', { name: 'Approve' }).click();
222222
await page.bringToFront();
223-
224-
await expect(page.getByText('Successfully connected', { exact: false })).toBeVisible({
225-
timeout: 30_000,
226-
});
223+
await expect(dialog.getByText('Address linked successfully')).toBeVisible();
224+
await dialog.getByRole('button', { name: 'Finish' }).click();
227225

228226
await page.close();
229227
});

0 commit comments

Comments
 (0)