Use *bool for the indexer optional bool parameters (#395)

* - Use *bool for the indexer HasTimelockCondition, HasExpirationCondition and RequiresStorageDepositReturn params, since omitempty will omit the default "false" value

* - Fixed test

Author: alexsporn

nodeclient/indexer_client_test.go

@@ -15,14 +15,15 @@ import (
 )
 
 func TestOutputsQuery_Build(t *testing.T) {
+	trueCondition := true
 	query := &nodeclient.BasicOutputsQuery{
 		IndexerTimelockParas: nodeclient.IndexerTimelockParas{
-			HasTimelockCondition: true,
+			HasTimelockCondition: &trueCondition,
 			TimelockedBefore:     1,
 			TimelockedAfter:      2,
 		},
 		IndexerExpirationParas: nodeclient.IndexerExpirationParas{
-			HasExpirationCondition: true,
+			HasExpirationCondition: &trueCondition,
 			ExpiresBefore:          5,
 			ExpiresAfter:           6,
 		},
@@ -31,7 +32,7 @@ func TestOutputsQuery_Build(t *testing.T) {
 			CreatedAfter:  10,
 		},
 		IndexerStorageDepositParas: nodeclient.IndexerStorageDepositParas{
-			RequiresStorageDepositReturn:      true,
+			RequiresStorageDepositReturn:      &trueCondition,
 			StorageDepositReturnAddressBech32: "",
 		},
 		AddressBech32: "alice",

nodeclient/indexer_models.go

@@ -29,7 +29,7 @@ type IndexerCursorParas struct {
 // IndexerTimelockParas define timelock query parameters.
 type IndexerTimelockParas struct {
 	// Filters outputs based on the presence of timelock unlock condition.
-	HasTimelockCondition bool `qs:"hasTimelockCondition,omitempty"`
+	HasTimelockCondition *bool `qs:"hasTimelockCondition,omitempty"`
 	// Return outputs that are timelocked before a certain Unix timestamp.
 	TimelockedBefore uint32 `qs:"timelockedBefore,omitempty"`
 	// Return outputs that are timelocked after a certain Unix timestamp.
@@ -39,7 +39,7 @@ type IndexerTimelockParas struct {
 // IndexerExpirationParas define expiration query parameters.
 type IndexerExpirationParas struct {
 	// Filters outputs based on the presence of expiration unlock condition.
-	HasExpirationCondition bool `qs:"hasExpirationCondition,omitempty"`
+	HasExpirationCondition *bool `qs:"hasExpirationCondition,omitempty"`
 	// Return outputs that expire before a certain Unix timestamp.
 	ExpiresBefore uint32 `qs:"expiresBefore,omitempty"`
 	// Return outputs that expire after a certain Unix timestamp.
@@ -59,7 +59,7 @@ type IndexerCreationParas struct {
 // IndexerStorageDepositParas define storage deposit based query parameters.
 type IndexerStorageDepositParas struct {
 	// Filters outputs based on the presence of storage deposit return unlock condition.
-	RequiresStorageDepositReturn bool `qs:"requiresStorageDepositReturn,omitempty"`
+	RequiresStorageDepositReturn *bool `qs:"requiresStorageDepositReturn,omitempty"`
 	// Filter outputs based on the presence of a specific return address in the storage deposit return unlock condition.
 	StorageDepositReturnAddressBech32 string `qs:"storageDepositAddress,omitempty"`
 }