chore: code improvements low severity (#123)

* chore: mitigate 1

* chore: mitigate 2

* chore: mitigate 3

* chore: mitigate 4

* chore: mitigate 5

* chore: mitigate 6

* fix: remove true flag from migrateFunds and explorer variable name changes

* fix: variable renaming

---------

Co-authored-by: Branko Bosnic <[email protected]>

Author: begonaalvarezd

packages/desktop/wallet.log

@@ -39,7 +39,6 @@ const LEGACY_ADDRESS_WITHOUT_CHECKSUM_LENGTH = 81
 export const LOG_FILE_NAME = 'migration.log'
 
 export const MIGRATION_NODES = ['https://nodes.iota.org', 'https://nodes.iota.cafe']
-export const PERMANODE = 'https://chronicle.iota.org/api'
 
 export const ADDRESS_SECURITY_LEVEL = 2
 

packages/shared/lib/migration.ts

@@ -12,12 +12,13 @@ import { activeProfile } from './profile'
 export const CHRYSALIS_MAINNET_ID = 'chrysalis-mainnet'
 export const CHRYSALIS_MAINNET_NAME = 'Chrysalis Mainnet'
 export const CHRYSALIS_MAINNET_BECH32_HRP = 'iota'
-export const CHRYSALIS_MAINNET_EXPLORER = 'https://explorer.iota.org/mainnet'
 
 export const CHRYSALIS_DEVNET_ID = 'chrysalis-devnet'
 export const CHRYSALIS_DEVNET_NAME = 'Chrysalis Devnet'
 export const CHRYSALIS_DEVNET_BECH32_HRP = 'atoi'
-export const CHRYSALIS_DEVNET_EXPLORER = 'https://explorer.iota.org/devnet'
+
+export const MAINNET_EXPLORER = 'https://explorer.iota.org/mainnet'
+export const DEVNET_EXPLORER = 'https://explorer.iota-alphanet.iotaledger.net/devnet'
 
 /**
  * Given the type of IOTA network, construct the default official network
@@ -109,9 +110,9 @@ const getOfficialNode = (type: NetworkType, url: string): Node => ({
 export const getOfficialExplorer = (networkId: NetworkId): string => {
     switch (networkId) {
         case CHRYSALIS_MAINNET_ID:
-            return CHRYSALIS_MAINNET_EXPLORER
+            return MAINNET_EXPLORER
         case CHRYSALIS_DEVNET_ID:
-            return CHRYSALIS_DEVNET_EXPLORER
+            return DEVNET_EXPLORER
         default:
             return ''
     }

packages/shared/lib/network.ts

@@ -55,13 +55,11 @@
     let error = getError(balance)
     let formattedBalance = formatUnitBestMatch(balance, true)
 
-    // TODO: add missing unsubscribe to onDestroy
     bundles.subscribe((updatedBundles) => {
         _bundles = updatedBundles
         error = getError(_data.balance)
     })
 
-    // TODO: add missing unsubscribe to onDestroy
     unselectedInputs.subscribe(() => {
         error = getError(_data.balance)
     })
@@ -130,7 +128,6 @@
     function checkAgain(): void {
         isCheckingForBalance = true
         if (legacyLedger) {
-            // TODO: add ledger legacy popup when PR merged
             const _onConnected = () => {
                 Platform.ledger
                     .selectSeed($hardwareIndexes.accountIndex, $hardwareIndexes.pageIndex, ADDRESS_SECURITY_LEVEL)

packages/shared/routes/setup/Balance.svelte

@@ -20,6 +20,7 @@
     import { SetupType } from 'shared/lib/typings/setup'
     import { formatUnitBestMatch } from 'shared/lib/units'
     import { api, walletSetupType } from 'shared/lib/wallet'
+    import { MAINNET_EXPLORER, DEVNET_EXPLORER } from 'shared/lib/network'
     import { onMount } from 'svelte'
     import { get } from 'svelte/store'
 
@@ -109,13 +110,8 @@
     }
 
     function consultExplorerClick() {
-        let urlToOpen = ''
-        if ($activeProfile.isDeveloperProfile) {
-            urlToOpen = `https://explorer.iota-alphanet.iotaledger.net/devnet/addr/${$migrationAddress.bech32}`
-        } else {
-            urlToOpen = `https://explorer.iota.org/mainnet/addr/${$migrationAddress.bech32}`
-        }
-        Platform.openUrl(urlToOpen)
+        const baseUrl = $activeProfile.isDeveloperProfile ? DEVNET_EXPLORER : MAINNET_EXPLORER
+        Platform.openUrl(`${baseUrl}/addr/${$migrationAddress.bech32}`)
     }
 
     function migrateAnotherProfile(): void {

packages/shared/routes/setup/Congratulations.svelte

@@ -11,7 +11,6 @@
         Text,
     } from 'shared/components'
     import { stage } from 'shared/lib/app'
-    import { initAppSettings } from 'shared/lib/appSettings'
     import { initialiseMigrationListeners } from 'shared/lib/migration'
     import { showAppNotification } from 'shared/lib/notifications'
     import { Platform } from 'shared/lib/platform'
@@ -23,9 +22,6 @@
 
     export let locale: Locale
 
-    let error = ''
-    let busy = false
-
     const TMP_PROFILE_NAME = 'MigrationProfile'
     let isDeveloperProfile = $newProfile?.isDeveloperProfile ?? get(stage) !== Stage.PROD
 
@@ -38,7 +34,7 @@
         try {
             validateProfileName(trimmedProfileName)
         } catch (err) {
-            return (error = err.message)
+            return
         }
         cleanUpIfPreviouslyInitialized()
         await initialiseProfileAndContinue(trimmedProfileName)
@@ -53,7 +49,6 @@
 
     async function initialiseProfileAndContinue(name: string): Promise<void> {
         try {
-            busy = true
             if (hasDeveloperProfileChanged) {
                 storeProfile(name, isDeveloperProfile)
 
@@ -78,8 +73,6 @@
                 type: 'error',
                 message: locale(err.error ? err.error : 'error.global.generic'),
             })
-        } finally {
-            busy = false
         }
     }
 </script>

packages/shared/routes/setup/Welcome.svelte

@@ -56,8 +56,6 @@
 
     let timeout
 
-    let singleMigrationBundleHash
-
     let hasError: boolean = false
 
     const legacyLedger = $walletSetupType === SetupType.TrinityLedger
@@ -95,7 +93,6 @@
                         })
                         .then(({ trytes, bundleHash }) => {
                             closePopup(true) // close transaction popup
-                            singleMigrationBundleHash = bundleHash
                             const reverseTrytesLedger = trytes.reverse()
                             updateMigrationLog(get(migrationLog).length - 1, {
                                 trytes: reverseTrytesLedger,

packages/shared/routes/setup/migrate/views/Migrate.svelte

@@ -158,7 +158,7 @@
             return item
         })
 
-        migrateFunds(true)
+        migrateFunds()
     }
 
     function persistProfile() {
@@ -201,7 +201,7 @@
         }
     }
 
-    function migrateFunds(isRerun?: boolean) {
+    function migrateFunds() {
         migratingFundsMessage = locale('views.migrate.migrating')
 
         transactions.reduce(