fix: add logs for canceled transaction & improve notifications for ledger devices (#116)

Author: brancoder

packages/shared/routes/setup/migrate/views/Migrate.svelte

@@ -85,6 +85,7 @@
                         .selectSeed($hardwareIndexes.accountIndex, $hardwareIndexes.pageIndex, ADDRESS_SECURITY_LEVEL)
                         .then(({ iota, callback }) => {
                             closeTransport = callback
+                            prepareMigrationLog([], migratableBalance)
                             return createLedgerMigrationBundle(
                                 0,
                                 get(migrationAddress),
@@ -96,7 +97,10 @@
                             closePopup(true) // close transaction popup
                             singleMigrationBundleHash = bundleHash
                             const reverseTrytesLedger = trytes.reverse()
-                            prepareMigrationLog(reverseTrytesLedger, migratableBalance, bundleHash)
+                            updateMigrationLog(get(migrationLog).length - 1, {
+                                trytes: reverseTrytesLedger,
+                                bundleHash,
+                            })
                             return sendOffLedgerMigrationRequest(reverseTrytesLedger, 0)
                         })
                         .then((receipt) => {
@@ -114,7 +118,7 @@
                             }
                         })
                         .catch((err) => {
-                            const error = err?.message ? err.message : err?.toString()
+                            const error = err?.message ?? err?.toString()
                             loading = false
                             closePopup(true) // close transaction popup
                             closeTransport()
@@ -154,7 +158,7 @@
                         }
                     })
                     .catch((err) => {
-                        const error = err?.message ? err.message : err.toString()
+                        const error = err?.message ?? err?.toString()
                         loading = false
                         showAppNotification({
                             type: 'error',

packages/shared/routes/setup/migrate/views/TransferFragmentedFunds.svelte

@@ -5,6 +5,7 @@
     import { Platform } from 'shared/lib/platform'
     import {
         displayNotificationForLedgerProfile,
+        getLegacyErrorMessage,
         ledgerDeviceState,
         promptUserToConnectLedger,
     } from 'shared/lib/ledger'
@@ -218,6 +219,7 @@
                                       )
                                       .then(({ iota, callback }) => {
                                           closeTransport = callback
+                                          prepareMigrationLog([], transaction.balance)
                                           return createLedgerMigrationBundle(
                                               transaction.index,
                                               get(migrationAddress),
@@ -235,7 +237,10 @@
                                               return _transaction
                                           })
                                           const reverseTrytesLedger = trytes.reverse()
-                                          prepareMigrationLog(reverseTrytesLedger, transaction.balance, bundleHash)
+                                          updateMigrationLog(get(migrationLog).length - 1, {
+                                              trytes: reverseTrytesLedger,
+                                              bundleHash,
+                                          })
                                           return sendOffLedgerMigrationRequest(reverseTrytesLedger, transaction.index)
                                       })
                                       .then((receipt) => {
@@ -250,10 +255,20 @@
                                           }
                                       })
                                       .catch((err) => {
-                                          const error = err?.message ? err.message : err?.toString()
+                                          const error = err?.message ?? err?.toString()
                                           updateMigrationLog(get(migrationLog).length - 1, { errorMessage: error })
                                           addMigrationError(error)
-                                          throw new Error(err)
+
+                                          closePopup(true) // close transaction popup
+                                          closeTransport()
+                                          displayNotificationForLedgerProfile('error', false, true, false, true, err)
+
+                                          const legacyErrorMessage = getLegacyErrorMessage(err)
+                                          throw new Error(
+                                              legacyErrorMessage === 'error.global.generic'
+                                                  ? error
+                                                  : locale(legacyErrorMessage)
+                                          )
                                       })
                               } else {
                                   setMigratingTransaction(transaction, 1)
@@ -276,7 +291,7 @@
                                           }
                                       })
                                       .catch((err) => {
-                                          const error = err?.message ? err.message : err?.toString()
+                                          const error = err?.message ?? err?.toString()
                                           updateMigrationLog(get(migrationLog).length - 1, { errorMessage: error })
                                           addMigrationError(error)
                                           throw new Error(err)
@@ -286,11 +301,6 @@
                           .catch((error) => {
                               console.error(error)
 
-                              if (legacyLedger) {
-                                  closePopup(true) // close transaction popup
-                                  closeTransport()
-                                  displayNotificationForLedgerProfile('error', false, true, false, true, error)
-                              }
                               showAppNotification({
                                   type: 'error',
                                   message: error.message || 'Failed to prepare transfers',