refactor: Simplify function signatures in client and handler modules

Author: itsyaasir

audit-trail-rs/src/client/full_client.rs

@@ -67,11 +67,11 @@ impl<S> AuditTrailClient<S> {
         AuditTrailBuilder::new()
     }
 
-    pub async fn migrate(&self, _trail_id: ObjectID, _cap_id: ObjectID) -> Result<(), Error> {
+    pub async fn migrate(&self, _trail_id: ObjectID) -> Result<(), Error> {
         Err(Error::NotImplemented("AuditTrailClient::migrate"))
     }
 
-    pub async fn delete_trail(&self, _trail_id: ObjectID, _cap_id: ObjectID) -> Result<(), Error> {
+    pub async fn delete_trail(&self, _trail_id: ObjectID) -> Result<(), Error> {
         Err(Error::NotImplemented("AuditTrailClient::delete_trail"))
     }
 }

audit-trail-rs/src/core/handler/capabilities.rs

@@ -17,14 +17,14 @@ impl<'a, C> TrailCapabilities<'a, C> {
         Self { client, trail_id }
     }
 
-    pub async fn issue(&self, _cap_id: ObjectID, _role: String) -> Result<(), Error>
+    pub async fn issue(&self, _role: String) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {
         Err(Error::NotImplemented("TrailCapabilities::issue"))
     }
 
-    pub async fn revoke(&self, _cap_id: ObjectID, _capability_id: ObjectID) -> Result<(), Error>
+    pub async fn revoke(&self, _capability_id: ObjectID) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {

audit-trail-rs/src/core/handler/locking.rs

@@ -18,14 +18,14 @@ impl<'a, C> TrailLocking<'a, C> {
         Self { client, trail_id }
     }
 
-    pub async fn update(&self, _cap_id: ObjectID, _config: LockingConfig) -> Result<(), Error>
+    pub async fn update(&self, _config: LockingConfig) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {
         Err(Error::NotImplemented("TrailLocking::update"))
     }
 
-    pub async fn update_delete_record_window(&self, _cap_id: ObjectID, _window: LockingWindow) -> Result<(), Error>
+    pub async fn update_delete_record_window(&self, _window: LockingWindow) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {

audit-trail-rs/src/core/handler/records.rs

@@ -92,13 +92,7 @@ impl<'a, C, D> TrailRecords<'a, C, D> {
         )))
     }
 
-    pub async fn correct(
-        &self,
-        _cap_id: ObjectID,
-        _replaces: Vec<u64>,
-        _data: D,
-        _metadata: Option<String>,
-    ) -> Result<(), Error>
+    pub async fn correct(&self, _replaces: Vec<u64>, _data: D, _metadata: Option<String>) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {

audit-trail-rs/src/core/handler/roles.rs

@@ -24,33 +24,23 @@ impl<'a, C> TrailRoles<'a, C> {
     }
 
     /// Creates a new role with the provided permissions.
-    pub async fn create(
-        &self,
-        _cap_id: ObjectID,
-        _name: impl Into<String>,
-        _permissions: PermissionSet,
-    ) -> Result<(), Error>
+    pub async fn create(&self, _name: impl Into<String>, _permissions: PermissionSet) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {
         Err(Error::NotImplemented("TrailRoles::create"))
     }
 
     /// Updates permissions for an existing role.
-    pub async fn update(
-        &self,
-        _cap_id: ObjectID,
-        _name: impl Into<String>,
-        _permissions: PermissionSet,
-    ) -> Result<(), Error>
+    pub async fn update(&self, _name: impl Into<String>, _permissions: PermissionSet) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {
         Err(Error::NotImplemented("TrailRoles::update"))
     }
 
     /// Deletes an existing role.
-    pub async fn delete(&self, _cap_id: ObjectID, _name: impl Into<String>) -> Result<(), Error>
+    pub async fn delete(&self, _name: impl Into<String>) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {
@@ -67,27 +57,23 @@ pub struct RoleHandle<'a, C> {
 
 impl<'a, C> RoleHandle<'a, C> {
     pub(crate) fn new(client: &'a C, trail_id: ObjectID, name: String) -> Self {
-        Self {
-            client,
-            trail_id,
-            name,
-        }
+        Self { client, trail_id, name }
     }
 
     pub fn name(&self) -> &str {
         &self.name
     }
 
     /// Updates permissions for this role.
-    pub async fn update_permissions(&self, _cap_id: ObjectID, _permissions: PermissionSet) -> Result<(), Error>
+    pub async fn update_permissions(&self, _permissions: PermissionSet) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {
         Err(Error::NotImplemented("RoleHandle::update_permissions"))
     }
 
     /// Deletes this role.
-    pub async fn delete(&self, _cap_id: ObjectID) -> Result<(), Error>
+    pub async fn delete(&self) -> Result<(), Error>
     where
         C: AuditTrailFull,
     {

audit-trail-rs/src/core/types/audit_trail.rs

@@ -5,6 +5,8 @@ use iota_interaction::types::base_types::IotaAddress;
 use iota_interaction::types::id::UID;
 use serde::{Deserialize, Serialize};
 
+use crate::core::types::Data;
+
 use super::locking::LockingConfig;
 use super::metadata::ImmutableMetadata;
 use super::permission::Permission;
@@ -13,7 +15,7 @@ use super::role_map::RoleMap;
 
 /// An audit trail stored on-chain.
 #[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
-pub struct AuditTrail<D = super::record::Data> {
+pub struct AuditTrail<D = Data> {
     pub id: UID,
     pub creator: IotaAddress,
     pub created_at: u64,

audit-trail-rs/src/core/types/record_correction.rs

@@ -6,20 +6,13 @@ use std::collections::HashSet;
 use serde::{Deserialize, Serialize};
 
 /// Bidirectional correction tracking for audit records.
-#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
+#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, Default)]
 pub struct RecordCorrection {
     pub replaces: HashSet<u64>,
     pub is_replaced_by: Option<u64>,
 }
 
 impl RecordCorrection {
-    pub fn new() -> Self {
-        Self {
-            replaces: HashSet::new(),
-            is_replaced_by: None,
-        }
-    }
-
     pub fn with_replaces(replaces: HashSet<u64>) -> Self {
         Self {
             replaces,