refactor: lower-case error messages (#42)

* refactor: lower-case error messages

* fix: bump version and rust toolchain

* fix: cargo deny

* fixup! refactor: lower-case error messages

Author: sergiupopescu199

Cargo.lock

@@ -1,6 +1,6 @@
 [package]
 name = "rebased-stardust-indexer"
-version = "0.5.0"
+version = "0.5.1"
 edition = "2021"
 
 [dependencies]

Cargo.toml

@@ -18,8 +18,6 @@
 # dependencies not shared by any other crates, would be ignored, as the target
 # list here is effectively saying which targets you are building for.
 targets = [
-
-
     # The triple can be any string, but only the target triples built in to
     # rustc (as of 1.40) can be checked against actual config expressions
     # { triple = "x86_64-unknown-linux-musl" },
@@ -48,13 +46,27 @@ ignore = [
     "RUSTSEC-2024-0370",
     # yaml-rust is unmaintained
     "RUSTSEC-2024-0320",
-    # difference is unmaintained
-    "RUSTSEC-2020-0095",
+    # # difference is unmaintained
+    # "RUSTSEC-2020-0095",
     # derivative is unmaintained
     "RUSTSEC-2024-0388",
     # instant is unmaintained
     "RUSTSEC-2024-0384",
+    # paste is unmaintained
+    "RUSTSEC-2024-0436",
+    # backoff is unmaintained
+    "RUSTSEC-2025-0012",
+    # Logging user input may result in poisoning logs with ANSI escape sequences
+    "RUSTSEC-2025-0055",
+
+    # these shall be fixed once we update the iota dependencies
+    #
+    # tokio: Broadcast channel calls clone in parallel, but does not require `Sync`
+    "RUSTSEC-2025-0023",
+    # protobuf: Crash due to uncontrolled recursion in protobuf crate
+    "RUSTSEC-2024-0437"
 ]
+
 # Threshold for security vulnerabilities, any vulnerability with a CVSS score
 # lower than the range specified will be ignored. Note that ignored advisories
 # will still output a note when they are encountered.
@@ -159,8 +171,6 @@ ignore = false
 # is only published to private registries, and ignore is true, the crate will
 # not have its license(s) checked
 registries = [
-
-
     # "https://sekretz.com/registry
 ]
 
@@ -180,14 +190,10 @@ wildcards = "allow"
 highlight = "all"
 # List of crates that are allowed. Use with care!
 allow = [
-
-
     # { name = "ansi_term", version = "=0.11.0" },
 ]
 # List of crates to deny
 deny = [
-
-
     # Each entry the name of a crate and a version range. If version is
     # not specified, all versions will be matched.
     # { name = "ansi_term", version = "=0.11.0" },
@@ -198,8 +204,6 @@ deny = [
 ]
 # Certain crates/versions that will be skipped when doing duplicate detection.
 skip = [
-
-
     # { name = "ansi_term", version = "=0.11.0" },
 ]
 # Similarly to `skip` allows you to skip certain crates during duplicate
@@ -237,4 +241,4 @@ allow-git = [
     "https://github.com/bmwill/openapiv3.git",
 ]
 
-[sources.allow-org]
+[sources.allow-org]

deny.toml

@@ -1,2 +1,2 @@
 [toolchain]
-channel = "1.85"
+channel = "1.88"

rust-toolchain.toml

@@ -113,8 +113,8 @@ impl ConnectionPool {
             Name::ProgressStore => "PROGRESS_STORE_DB_URL",
         };
 
-        let database_url =
-            env::var(db_url_env_var).unwrap_or_else(|_| panic!("{db_url_env_var} must be set"));
+        let database_url = env::var(db_url_env_var)
+            .unwrap_or_else(|_| panic!("the {db_url_env_var} environment variable must be set"));
         Self::new_with_url(&database_url, pool_config, db_name)
     }
 

src/db.rs

@@ -110,7 +110,7 @@ async fn run_indexer(
     // Spawn the REST server
     spawn_rest_server(rest_api_address, connection_pool, token)
         .await
-        .inspect_err(|e| error!("REST server terminated with error: {e}"))?;
+        .inspect_err(|e| error!("rest server terminated with error: {e}"))?;
 
     Ok(())
 }

src/main.rs

@@ -73,9 +73,9 @@ pub(crate) fn spawn_prometheus_server(
         // Attempt to bind the socket
         let listener = tokio::net::TcpListener::bind(socket_addr)
             .await
-            .map_err(|e| anyhow::anyhow!("Failed to bind to socket {}: {}", socket_addr, e))?;
+            .map_err(|e| anyhow::anyhow!("failed to bind to socket {socket_addr}: {e}"))?;
 
-        info!("Listening on: {}", socket_addr);
+        info!("Listening on: {socket_addr}");
 
         let app = Router::new()
             .route(METRICS_ROUTE, get(metrics))
@@ -88,7 +88,7 @@ pub(crate) fn spawn_prometheus_server(
                 info!("Shutdown signal received.");
             })
             .await
-            .map_err(|e| anyhow::anyhow!("Server encountered an error: {}", e))?;
+            .map_err(|e| anyhow::anyhow!("server encountered an error: {e}"))?;
 
         Ok(())
     });

src/metrics.rs

@@ -26,8 +26,7 @@ where
         match AxumPath::<T>::from_request_parts(parts, state).await {
             Ok(value) => Ok(Self(value.0)),
             Err(e) => Err(ApiError::BadRequest(format!(
-                "invalid path parameter provided: {}",
-                e
+                "invalid path parameter provided: {e}"
             ))),
         }
     }

src/rest/extractors.rs

@@ -58,7 +58,7 @@ pub(crate) fn spawn_rest_server(
                 info!("Shutdown signal received.");
             })
             .await
-            .inspect_err(|e| error!("Server encountered an error: {e}"))
+            .inspect_err(|e| error!("server encountered an error: {e}"))
             .ok();
     })
 }

src/rest/mod.rs

@@ -28,12 +28,12 @@ use crate::{
 pub(crate) async fn health(Extension(state): Extension<State>) -> Result<HealthResponse, ApiError> {
     let mut conn = state.connection_pool.get_connection().map_err(|e| {
         error!("failed to get connection: {e}");
-        ApiError::ServiceUnavailable(format!("failed to get connection: {}", e))
+        ApiError::ServiceUnavailable(format!("failed to get connection: {e}"))
     })?;
 
     let objects_count = objects.count().get_result(&mut conn).map_err(|e| {
         error!("failed to count objects: {e}");
-        ApiError::ServiceUnavailable(format!("failed to count objects: {}", e))
+        ApiError::ServiceUnavailable(format!("failed to count objects: {e}"))
     })?;
 
     let basic_objects_count = objects